Skip to content

Commit 9b23c08

Browse files
committed
wasmstdlib.py: embedded stdlib not built for threads, exclude its tests
1 parent 58a6dc2 commit 9b23c08

File tree

1 file changed

+14
-1
lines changed
  • utils/swift_build_support/swift_build_support/products

1 file changed

+14
-1
lines changed

utils/swift_build_support/swift_build_support/products/wasmstdlib.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,9 @@ def add_extra_cmake_options(self):
213213
self.cmake_options.define('SWIFT_THREADING_PACKAGE:STRING', 'none')
214214

215215
def test(self, host_target):
216+
self._test(host_target, 'wasm32-wasip1')
217+
218+
def _test(self, host_target, target_triple):
216219
build_root = os.path.dirname(self.build_dir)
217220
bin_paths = [
218221
os.path.join(self._host_swift_build_dir(host_target), 'bin'),
@@ -234,7 +237,14 @@ def test(self, host_target):
234237
'LIT_FILTER_OUT':
235238
'(Concurrency/Runtime/clock.swift|stdlib/StringIndex.swift)',
236239
}
237-
self.test_with_cmake(None, [test_target, 'check-swift-embedded-wasi'], self._build_variant, [], test_env=env)
240+
241+
# Embedded stdlib is not built for the threads triple, don't include embedded tests for it.
242+
if target_triple == 'wasm32-wasip1-threads':
243+
test_targets = [test_target]
244+
else:
245+
test_targets = [test_target, 'check-swift-embedded-wasi']
246+
247+
self.test_with_cmake(None, test_targets, self._build_variant, [], test_env=env)
238248

239249
def should_test_executable(self) -> bool:
240250
return True
@@ -271,6 +281,9 @@ class WasmThreadsStdlib(WasmStdlib):
271281
def build(self, host_target):
272282
self._build(host_target, 'wasm32-wasip1-threads', 'wasip1-threads-wasm32')
273283

284+
def test(self, host_target):
285+
self._test(host_target, 'wasm32-wasip1-threads')
286+
274287
def should_test_executable(self):
275288
# TODO(katei): Enable tests once WasmKit supports WASI threads
276289
return False

0 commit comments

Comments
 (0)