File tree Expand file tree Collapse file tree 1 file changed +1
-1
lines changed Expand file tree Collapse file tree 1 file changed +1
-1
lines changed Original file line number Diff line number Diff line change @@ -186,7 +186,7 @@ Smaller changes (or changes where the developer owns the component) can be revie
186
186
- Code reviews are conducted on GitHub (through comments on pull requests or commits) and are reflected on the relevant project’s commit mailing list.
187
187
- The developer responsible for a code change is also responsible for making all necessary review-related changes.
188
188
189
- Code review can be an iterative process, which continues until the change is ready to be committed .
189
+ Code review can be an iterative process, which continues until the change is ready to be merged .
190
190
After a change is sent out for review it needs an explicit approval before it’s submitted.
191
191
Do not assume silent approval or request active objections to the patch by setting a deadline.
192
192
You can’t perform that action at this time.
0 commit comments