ASTDemangler: Fix demangling of weak/unowned/unowned(unsafe)

The check here was incorrect because we might have an optional of a
reference type as well. Just remove the check to keep things simple.

Author: slavapestov

lib/AST/ASTDemangler.cpp

@@ -497,8 +497,6 @@ Type ASTBuilder::createDependentMemberType(StringRef member,
 
 #define REF_STORAGE(Name, ...) \
 Type ASTBuilder::create##Name##StorageType(Type base) { \
-  if (!base->allowsOwnership()) \
-    return Type(); \
   return Name##StorageType::get(base, Ctx); \
 }
 #include "swift/AST/ReferenceStorage.def"

test/TypeDecoder/reference_storage.swift

@@ -0,0 +1,26 @@
+// RUN: %empty-directory(%t)
+
+// RUN: %target-build-swift -emit-executable %s -g -o %t/reference_storage -emit-module
+// RUN: sed -ne '/\/\/ *DEMANGLE: /s/\/\/ *DEMANGLE: *//p' < %s > %t/input
+// RUN: %lldb-moduleimport-test %t/reference_storage -type-from-mangled=%t/input | %FileCheck %s
+
+func blackHole(_: Any...) {}
+
+class Class {}
+
+
+let c = Class()
+
+weak var weakVar: Class? = c
+unowned let unownedVar: Class = c
+unowned(unsafe) let unmanagedVar: Class = c
+
+blackHole(weakVar, unownedVar, unmanagedVar)
+
+// DEMANGLE: $s17reference_storage5ClassCSgXwD
+// DEMANGLE: $s17reference_storage5ClassCXoD
+// DEMANGLE: $s17reference_storage5ClassCXuD
+
+// CHECK: @sil_weak Optional<Class>
+// CHECK: @sil_unowned Class
+// CHECK: @sil_unmanaged Class

tools/lldb-moduleimport-test/lldb-moduleimport-test.cpp

@@ -17,6 +17,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "swift/AST/ASTDemangler.h"
+#include "swift/AST/PrintOptions.h"
 #include "swift/ASTSectionImporter/ASTSectionImporter.h"
 #include "swift/Frontend/Frontend.h"
 #include "swift/IDE/Utils.h"
@@ -99,7 +100,9 @@ static void resolveTypeFromMangledNameList(
     if (!ResolvedType) {
       llvm::outs() << "Can't resolve type of " << Mangled << "\n";
     } else {
-      ResolvedType->print(llvm::outs());
+      swift::PrintOptions PO;
+      PO.PrintStorageRepresentationAttrs = true;
+      ResolvedType->print(llvm::outs(), PO);
       llvm::outs() << "\n";
     }
   }
@@ -114,7 +117,9 @@ static void resolveTypeFromMangledNameListOld(
     if (!ResolvedType) {
       llvm::errs() << "Can't resolve type of " << Mangled << "\n";
     } else {
-      ResolvedType->print(llvm::errs());
+      swift::PrintOptions PO;
+      PO.PrintStorageRepresentationAttrs = true;
+      ResolvedType->print(llvm::errs(), PO);
       llvm::errs() << "\n";
     }
   }