Skip to content

Commit 9e76023

Browse files
committed
Add BuiltinCreateTaskGroupWithFlags feature and use it to guard the builtin
1 parent e2842c7 commit 9e76023

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

include/swift/Basic/Features.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ LANGUAGE_FEATURE(BuiltinTaskRunInline, 0, "Builtin.taskRunInline", true)
8686
LANGUAGE_FEATURE(BuiltinUnprotectedAddressOf, 0, "Builtin.unprotectedAddressOf", true)
8787
SUPPRESSIBLE_LANGUAGE_FEATURE(SpecializeAttributeWithAvailability, 0, "@_specialize attribute with availability", true)
8888
LANGUAGE_FEATURE(BuiltinAssumeAlignment, 0, "Builtin.assumeAlignment", true)
89+
LANGUAGE_FEATURE(BuiltinCreateTaskGroupWithFlags, 0, "Builtin.createTaskGroupWithFlags", true)
8990
SUPPRESSIBLE_LANGUAGE_FEATURE(UnsafeInheritExecutor, 0, "@_unsafeInheritExecutor", true)
9091
SUPPRESSIBLE_LANGUAGE_FEATURE(PrimaryAssociatedTypes2, 346, "Primary associated types", true)
9192
SUPPRESSIBLE_LANGUAGE_FEATURE(UnavailableFromAsync, 0, "@_unavailableFromAsync", true)

lib/AST/ASTPrinter.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2938,6 +2938,10 @@ static bool usesFeatureBuiltinTaskRunInline(Decl *) { return false; }
29382938

29392939
static bool usesFeatureBuiltinUnprotectedAddressOf(Decl *) { return false; }
29402940

2941+
static bool usesFeatureBuiltinCreateTaskGroupWithFlags(Decl *decl) {
2942+
return false;
2943+
}
2944+
29412945
static bool usesFeatureSpecializeAttributeWithAvailability(Decl *decl) {
29422946
if (auto func = dyn_cast<AbstractFunctionDecl>(decl)) {
29432947
for (auto specialize : func->getAttrs().getAttributes<SpecializeAttr>()) {

stdlib/public/Concurrency/DiscardingTaskGroup.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public func withDiscardingTaskGroup<GroupResult>(
7474
returning returnType: GroupResult.Type = GroupResult.self,
7575
body: (inout DiscardingTaskGroup) async -> GroupResult
7676
) async -> GroupResult {
77-
#if compiler(>=5.5) && $BuiltinTaskGroupWithArgument
77+
#if compiler(>=5.5) && $BuiltinCreateTaskGroupWithFlags
7878
let flags = taskGroupCreateFlags(
7979
discardResults: true
8080
)
@@ -378,7 +378,7 @@ public func withThrowingDiscardingTaskGroup<GroupResult>(
378378
returning returnType: GroupResult.Type = GroupResult.self,
379379
body: (inout ThrowingDiscardingTaskGroup<Error>) async throws -> GroupResult
380380
) async throws -> GroupResult {
381-
#if compiler(>=5.5) && $BuiltinTaskGroupWithArgument
381+
#if compiler(>=5.5) && $BuiltinCreateTaskGroupWithFlags
382382
let flags = taskGroupCreateFlags(
383383
discardResults: true
384384
)

0 commit comments

Comments
 (0)