File tree Expand file tree Collapse file tree 5 files changed +6
-11
lines changed Expand file tree Collapse file tree 5 files changed +6
-11
lines changed Original file line number Diff line number Diff line change @@ -327,8 +327,7 @@ struct PrintOptions {
327
327
};
328
328
329
329
// / Whether to print function @convention attribute on function types.
330
- // FIXME: [clang-function-type-serialization] Once we start serializing Clang
331
- // types, we should also start printing the full type in the swiftinterface.
330
+ // [TODO: Clang-type-plumbing] Print the full type in the swiftinterface.
332
331
FunctionRepresentationMode PrintFunctionRepresentationAttrs =
333
332
FunctionRepresentationMode::NameOnly;
334
333
Original file line number Diff line number Diff line change @@ -3013,8 +3013,7 @@ class AnyFunctionType : public TypeBase {
3013
3013
static void assertIsFunctionType (const clang::Type *);
3014
3014
3015
3015
ExtInfo (unsigned Bits, Uncommon Other) : Bits(Bits), Other(Other) {
3016
- // TODO: [clang-function-type-serialization] Once we start serializing
3017
- // the Clang type, we should also assert that the pointer is non-null.
3016
+ // [TODO: Clang-type-plumbing] Assert that the pointer is non-null.
3018
3017
auto Rep = Representation (Bits & RepresentationMask);
3019
3018
if ((Rep == Representation::CFunctionPointer) && Other.ClangFunctionType )
3020
3019
assertIsFunctionType (Other.ClangFunctionType );
Original file line number Diff line number Diff line change @@ -274,8 +274,7 @@ namespace swift {
274
274
// / Use Clang function types for computing canonical types.
275
275
// / If this option is false, the clang function types will still be computed
276
276
// / but will not be used for checking type equality.
277
- // / FIXME: [clang-function-type-serialization] This option should be turned
278
- // / on once we start serializing clang function types.
277
+ // / [TODO: Clang-type-plumbing] Turn on for feature rollout.
279
278
bool UseClangFunctionTypes = false ;
280
279
281
280
// / Whether to use the import as member inference system
Original file line number Diff line number Diff line change @@ -33,7 +33,7 @@ struct ModuleInterfaceOptions {
33
33
bool PreserveTypesAsWritten = false ;
34
34
35
35
// / Should we emit the cType when printing @convention(c) or no?
36
- // / FIXME: [clang-function- type-serialization ] This check should go away.
36
+ // / [TODO: Clang- type-plumbing ] This check should go away.
37
37
bool PrintFullConvention = false ;
38
38
39
39
// / Copy of all the command-line flags passed at .swiftinterface
Original file line number Diff line number Diff line change @@ -4019,8 +4019,7 @@ class TypePrinter : public TypeVisitor<TypePrinter> {
4019
4019
break ;
4020
4020
case SILFunctionType::Representation::CFunctionPointer:
4021
4021
Printer << " c" ;
4022
- // FIXME: [clang-function-type-serialization] Once we start serializing
4023
- // Clang function types, we should be able to remove the second check.
4022
+ // [TODO: Clang-type-plumbing] Remove the second check.
4024
4023
if (printNameOnly || !info.getUncommonInfo ().hasValue ())
4025
4024
break ;
4026
4025
printCType (Ctx, Printer, info);
@@ -4086,8 +4085,7 @@ class TypePrinter : public TypeVisitor<TypePrinter> {
4086
4085
break ;
4087
4086
case SILFunctionType::Representation::CFunctionPointer:
4088
4087
Printer << " c" ;
4089
- // FIXME: [clang-function-type-serialization] Once we start serializing
4090
- // Clang function types, we should be able to remove the second check.
4088
+ // [TODO: Clang-type-plumbing] Remove the second check.
4091
4089
if (printNameOnly || !info.getUncommonInfo ().hasValue ())
4092
4090
break ;
4093
4091
printCType (Ctx, Printer, info);
You can’t perform that action at this time.
0 commit comments