Merge pull request swiftlang#27152 from save-buffer/fix_warnings

Fix warnings

Author: compnerd

include/swift/AST/PropertyWrappers.h

@@ -109,6 +109,7 @@ struct PropertyWrapperMutability {
       }
       return std::max(Getter, Setter);
     }
+    llvm_unreachable("Unhandled Value in switch");
   }
 
   bool operator==(PropertyWrapperMutability other) const {

include/swift/AST/Requirement.h

@@ -167,6 +167,7 @@ class Requirement {
     case RequirementKind::Layout:
       return lhs.getLayoutConstraint() == rhs.getLayoutConstraint();
     }
+    llvm_unreachable("Unhandled RequirementKind in switch");
   }
 };
 

include/swift/AST/ResilienceExpansion.h

@@ -54,6 +54,7 @@ inline llvm::raw_ostream &operator<<(llvm::raw_ostream &os,
   case ResilienceExpansion::Maximal:
     return os << "Maximal";
   }
+  llvm_unreachable("Unhandled ResilienceExpansion in switch");
 }
 
 } // namespace swift

include/swift/SIL/AbstractionPattern.h

@@ -402,6 +402,7 @@ class AbstractionPattern {
     case Kind::Tuple:
       return false;
     }
+    llvm_unreachable("Unhandled AbstractionPatternKind in switch");
   }
 
   CanGenericSignature getGenericSignature() const {

lib/AST/ASTContext.cpp

@@ -4477,6 +4477,7 @@ bool ASTContext::overrideGenericSignatureReqsSatisfied(
   case OverrideGenericSignatureReqCheck::DerivedReqSatisfiedByBase:
     return derivedSig->requirementsNotSatisfiedBy(sig).empty();
   }
+  llvm_unreachable("Unhandled OverrideGenericSignatureReqCheck in switch");
 }
 
 SILLayout *SILLayout::get(ASTContext &C,

lib/AST/ASTScope.cpp

@@ -53,7 +53,17 @@ Optional<bool> ASTScope::computeIsCascadingUse(
   return ASTScopeImpl::computeIsCascadingUse(history, initialIsCascadingUse);
 }
 
+#if SWIFT_COMPILER_IS_MSVC
+#pragma warning(push)
+#pragma warning(disable : 4996)
+#endif
+
 void ASTScope::dump() const { impl->dump(); }
+
+#if SWIFT_COMPILER_IS_MSVC
+#pragma warning(pop)
+#endif
+
 void ASTScope::print(llvm::raw_ostream &out) const { impl->print(out); }
 void ASTScope::dumpOneScopeMapLocation(std::pair<unsigned, unsigned> lineCol) {
   impl->dumpOneScopeMapLocation(lineCol);

lib/AST/ASTScopeCreation.cpp

@@ -1178,6 +1178,7 @@ ConditionalClauseScope::expandAScopeThatCreatesANewInsertionPoint(
     return {ccPatternUseScope,
             "Succeeding code must be in scope of conditional variables"};
   }
+  llvm_unreachable("Unhandled StmtConditionKind in switch");
 }
 
 AnnotatedInsertionPoint

lib/AST/Decl.cpp

@@ -7660,6 +7660,7 @@ ParseAbstractFunctionBodyRequest::getCachedResult() const {
   case BodyKind::Unparsed:
     return None;
   }
+  llvm_unreachable("Unhandled BodyKing in switch");
 }
 
 void ParseAbstractFunctionBodyRequest::cacheResult(BraceStmt *value) const {

lib/AST/DeclContext.cpp

@@ -1037,6 +1037,7 @@ SourceLoc swift::extractNearestSourceLoc(const DeclContext *dc) {
   case DeclContextKind::SerializedLocal:
     return extractNearestSourceLoc(dc->getParent());
   }
+  llvm_unreachable("Unhandled DeclCopntextKindin switch");
 }
 
 #define DECL(Id, Parent) \

lib/AST/GenericSignature.cpp

@@ -1091,4 +1091,5 @@ Requirement Requirement::getCanonical() const {
   case RequirementKind::Layout:
     return Requirement(getKind(), firstType, getLayoutConstraint());
   }
+  llvm_unreachable("Unhandled RequirementKind in switch");
 }