Add comment on required isConcrete specialization

nvzqz · nvzqz · commit a1f3cb98230a · 2019-08-27T16:51:09.000-07:00
When calling `Builtin.isConcrete` in SIL, the provided type parameter
should be sufficient.
diff --git a/test/IRGen/builtin_isConcrete.sil b/test/IRGen/builtin_isConcrete.sil
@@ -22,6 +22,7 @@ bb0(%0 : $@thin MyInt.Type):
 // CHECK-NEXT:  }
 sil @isConcrete_false : $@convention(thin) <T> (@thin T.Type) -> Builtin.Int1 {
 bb0(%0 : $@thin T.Type):
+  // FIXME: Explicit specialization is required here when it shouldn't be
   %1 = builtin "isConcrete"<T>(%0 : $@thin T.Type) : $Builtin.Int1
   return %1 : $Builtin.Int1
 }

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ bb0(%0 : $@thin MyInt.Type):`
`22`	`22`	`// CHECK-NEXT: }`
`23`	`23`	`sil @isConcrete_false : $@convention(thin) <T> (@thin T.Type) -> Builtin.Int1 {`
`24`	`24`	`bb0(%0 : $@thin T.Type):`
	`25`	`+ // FIXME: Explicit specialization is required here when it shouldn't be`
`25`	`26`	`%1 = builtin "isConcrete"<T>(%0 : $@thin T.Type) : $Builtin.Int1`
`26`	`27`	`return %1 : $Builtin.Int1`
`27`	`28`	`}`