Skip to content

Commit a303bb4

Browse files
committed
Disable SimplifyCFG::tailDuplicateObjCMethodCallSuccessorBlocks in OSSA
Support for this needs to be added
1 parent bf68e3f commit a303bb4

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/SILOptimizer/Transforms/SimplifyCFG.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2954,10 +2954,8 @@ static bool shouldTailDuplicate(SILBasicBlock &Block) {
29542954
bool SimplifyCFG::tailDuplicateObjCMethodCallSuccessorBlocks() {
29552955
SmallVector<SILBasicBlock *, 16> ObjCBlocks;
29562956

2957-
// TODO: OSSA phi support. Even if all block arguments are trivial,
2958-
// jump-threading may require creation of guaranteed phis, which may require
2959-
// creation of nested borrow scopes.
2960-
if (!EnableOSSARewriteTerminator && Fn.hasOwnership()) {
2957+
if (Fn.hasOwnership()) {
2958+
// TODO: This needs additional support in ossa.
29612959
return false;
29622960
}
29632961
// Collect blocks to tail duplicate.

0 commit comments

Comments
 (0)