Add no-op visitor in SILGenFunction for #warning/#error (swiftlang#15008)

harlanhaskins · web-flow · commit a42c5ce7336a · 2018-03-06T12:26:39.000-05:00
* Add no-op visitor in SILGenFunction for #warning/#error

* Switch to a compile-based test

* Actually add file substitution
diff --git a/lib/SILGen/SILGenFunction.h b/lib/SILGen/SILGenFunction.h
@@ -1682,6 +1682,10 @@ class LLVM_LIBRARY_VISIBILITY SILGenFunction
     // No lowering support needed.
   }
 
+  void visitPoundDiagnosticDecl(PoundDiagnosticDecl *D) {
+    // No lowering support needed.
+  }
+
   void visitVarDecl(VarDecl *D);
 
   /// Emit an Initialization for a 'var' or 'let' decl in a pattern.
diff --git a/test/Sema/pound_diagnostics.swift b/test/Sema/pound_diagnostics.swift
@@ -1,4 +1,5 @@
 // RUN: %target-typecheck-verify-swift
+// RUN: %target-swift-frontend -c -verify %s -o /dev/null
 
 #warning("this should be a warning") // expected-warning {{this should be a warning}}
 #error("this should be an error") // expected-error {{this should be an error}}

Original file line number	Diff line number	Diff line change
`@@ -1682,6 +1682,10 @@ class LLVM_LIBRARY_VISIBILITY SILGenFunction`
`1682`	`1682`	`// No lowering support needed.`
`1683`	`1683`	`}`
`1684`	`1684`
	`1685`	`+ void visitPoundDiagnosticDecl(PoundDiagnosticDecl *D) {`
	`1686`	`+ // No lowering support needed.`
	`1687`	`+ }`
	`1688`	`+`
`1685`	`1689`	`void visitVarDecl(VarDecl *D);`
`1686`	`1690`
`1687`	`1691`	`/// Emit an Initialization for a 'var' or 'let' decl in a pattern.`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`// RUN: %target-typecheck-verify-swift`
	`2`	`+// RUN: %target-swift-frontend -c -verify %s -o /dev/null`
`2`	`3`
`3`	`4`	`#warning("this should be a warning") // expected-warning {{this should be a warning}}`
`4`	`5`	`#error("this should be an error") // expected-error {{this should be an error}}`