Use withUnsafeBytes(of:) properly for getting the address of a local variable

Author: DougGregor

stdlib/public/Concurrency/TaskGroup.swift

@@ -218,9 +218,11 @@ public struct TaskGroup<ChildTaskResult> {
     flags.addPendingGroupTaskUnconditionally = true
 
     var groupOption = TaskOptionRecord.TaskGroup(group: _group)
-
-    // Create the asynchronous task future.
-    _ = Builtin.createAsyncTask(flags.bits, UnsafeRawPointer(&groupOption)._rawValue, operation)
+    withUnsafeBytes(of: &groupOption) { optionsBuffer in
+      // Create the asynchronous task future.
+      _ = Builtin.createAsyncTask(
+          flags.bits, optionsBuffer.baseAddress?._rawValue, operation)
+    }
   }
 
   /// Add a child task to the group.
@@ -255,9 +257,11 @@ public struct TaskGroup<ChildTaskResult> {
     flags.enqueueJob = true
 
     var groupOption = TaskOptionRecord.TaskGroup(group: _group)
-
-    // Create the asynchronous task future.
-    _ = Builtin.createAsyncTask(flags.bits, UnsafeRawPointer(&groupOption)._rawValue, operation)
+    withUnsafeBytes(of: &groupOption) { optionsBuffer in
+      // Create the asynchronous task future.
+      _ = Builtin.createAsyncTask(
+          flags.bits, optionsBuffer.baseAddress?._rawValue, operation)
+    }
 
     return true
   }
@@ -443,9 +447,11 @@ public struct ThrowingTaskGroup<ChildTaskResult, Failure: Error> {
     flags.addPendingGroupTaskUnconditionally = true
 
     var groupOption = TaskOptionRecord.TaskGroup(group: _group)
-
-    // Create the asynchronous task future.
-    _ = Builtin.createAsyncTask(flags.bits, UnsafeRawPointer(&groupOption)._rawValue, operation)
+    withUnsafeBytes(of: &groupOption) { optionsBuffer in
+      // Create the asynchronous task future.
+      _ = Builtin.createAsyncTask(
+          flags.bits, optionsBuffer.baseAddress?._rawValue, operation)
+    }
   }
 
   /// Add a child task to the group.
@@ -480,9 +486,11 @@ public struct ThrowingTaskGroup<ChildTaskResult, Failure: Error> {
     flags.enqueueJob = true
 
     var groupOption = TaskOptionRecord.TaskGroup(group: _group)
-
-    // Create the asynchronous task future.
-    _ = Builtin.createAsyncTask(flags.bits, UnsafeRawPointer(&groupOption)._rawValue, operation)
+    withUnsafeBytes(of: &groupOption) { optionsBuffer in
+      // Create the asynchronous task future.
+      _ = Builtin.createAsyncTask(
+          flags.bits, optionsBuffer.baseAddress?._rawValue, operation)
+    }
 
     return true
   }