Merge pull request swiftlang#34305 from DougGregor/concurrency-actor-isolation-serialization

[Concurrency] Proper serialization/interface printing for actor-isolation attributes

Author: DougGregor

include/swift/AST/TypeCheckRequests.h

@@ -2687,9 +2687,13 @@ enum class CustomAttrTypeKind {
   /// any contextual type parameters.
   NonGeneric,
 
-  /// Property delegates have some funky rules, like allowing
+  /// Property wrappers have some funky rules, like allowing
   /// unbound generic types.
-  PropertyDelegate,
+  PropertyWrapper,
+
+  /// Global actors are represented as custom type attributes. They don't
+  /// have any particularly interesting semantics.
+  GlobalActor,
 };
 
 void simple_display(llvm::raw_ostream &out, CustomAttrTypeKind value);

lib/AST/TypeCheckRequests.cpp

@@ -1467,8 +1467,12 @@ void swift::simple_display(llvm::raw_ostream &out, CustomAttrTypeKind value) {
     out << "non-generic";
     return;
 
-  case CustomAttrTypeKind::PropertyDelegate:
-    out << "property-delegate";
+  case CustomAttrTypeKind::PropertyWrapper:
+    out << "property-wrapper";
+    return;
+
+  case CustomAttrTypeKind::GlobalActor:
+    out << "global-actor";
     return;
   }
   llvm_unreachable("bad kind");

lib/Sema/TypeCheckConcurrency.cpp

@@ -25,6 +25,24 @@
 
 using namespace swift;
 
+/// Determine whether it makes sense to infer an attribute in the given
+/// context.
+static bool shouldInferAttributeInContext(const DeclContext *dc) {
+  auto sourceFile = dc->getParentSourceFile();
+  if (!sourceFile)
+    return false;
+
+  switch (sourceFile->Kind) {
+  case SourceFileKind::Interface:
+  case SourceFileKind::SIL:
+    return false;
+
+  case SourceFileKind::Library:
+  case SourceFileKind::Main:
+    return true;
+  }
+}
+
 /// Check whether the @asyncHandler attribute can be applied to the given
 /// function declaration.
 ///
@@ -108,7 +126,7 @@ bool IsAsyncHandlerRequest::evaluate(
     return true;
   }
 
-  if (!func->getASTContext().LangOpts.EnableExperimentalConcurrency)
+  if (!shouldInferAttributeInContext(func->getDeclContext()))
     return false;
 
   // Are we in a context where inference is possible?
@@ -1016,15 +1034,18 @@ static Optional<ActorIsolation> getIsolationFromAttributes(Decl *decl) {
   // If the declaration is marked with a global actor, report it as being
   // part of that global actor.
   if (globalActorAttr) {
-    TypeResolutionOptions options(TypeResolverContext::None);
-    TypeResolution resolver = TypeResolution::forInterface(
-        decl->getInnermostDeclContext(), options, nullptr);
-    Type globalActorType = resolver.resolveType(
-        globalActorAttr->first->getTypeRepr(), nullptr);
+    ASTContext &ctx = decl->getASTContext();
+    auto dc = decl->getInnermostDeclContext();
+    Type globalActorType = evaluateOrDefault(
+        ctx.evaluator,
+        CustomAttrTypeRequest{
+          globalActorAttr->first, dc, CustomAttrTypeKind::GlobalActor},
+        Type());
     if (!globalActorType || globalActorType->hasError())
       return ActorIsolation::forUnspecified();
 
-    return ActorIsolation::forGlobalActor(globalActorType);
+    return ActorIsolation::forGlobalActor(
+        globalActorType->mapTypeOutOfContext());
   }
 
   llvm_unreachable("Forgot about an attribute?");
@@ -1138,23 +1159,32 @@ ActorIsolation ActorIsolationRequest::evaluate(
   }
 
   // Disable inference of actor attributes outside of normal Swift source files.
-  if (auto sourceFile = value->getDeclContext()->getParentSourceFile()) {
-    switch (sourceFile->Kind) {
-    case SourceFileKind::Interface:
-    case SourceFileKind::SIL:
-      return defaultIsolation;
-
-    case SourceFileKind::Library:
-    case SourceFileKind::Main:
-      // Attempt inference below.
-      break;
-    }
-  } else {
+  if (!shouldInferAttributeInContext(value->getDeclContext()))
     return defaultIsolation;
-  }
 
   // Function used when returning an inferred isolation.
   auto inferredIsolation = [&](ActorIsolation inferred) {
+    // Add an implicit attribute to capture the actor isolation that was
+    // inferred, so that (e.g.) it will be printed and serialized.
+    ASTContext &ctx = value->getASTContext();
+    switch (inferred) {
+    case ActorIsolation::Independent:
+      value->getAttrs().add(new (ctx) ActorIndependentAttr(true));
+      break;
+
+    case ActorIsolation::GlobalActor: {
+      auto typeExpr = TypeExpr::createImplicit(inferred.getGlobalActor(), ctx);
+      auto attr = CustomAttr::create(
+          ctx, SourceLoc(), typeExpr, /*implicit=*/true);
+      value->getAttrs().add(attr);
+      break;
+    }
+
+    case ActorIsolation::ActorInstance:
+    case ActorIsolation::Unspecified:
+      // Nothing to do.
+      break;
+    }
     return inferred;
   };
 

lib/Sema/TypeCheckPropertyWrapper.cpp

@@ -512,7 +512,7 @@ Type AttachedPropertyWrapperTypeRequest::evaluate(Evaluator &evaluator,
   auto ty = evaluateOrDefault(
       evaluator,
       CustomAttrTypeRequest{customAttr, var->getDeclContext(),
-                            CustomAttrTypeKind::PropertyDelegate},
+                            CustomAttrTypeKind::PropertyWrapper},
       Type());
   if (!ty || ty->hasError()) {
     return ErrorType::get(var->getASTContext());

lib/Sema/TypeCheckType.cpp

@@ -3979,7 +3979,7 @@ Type CustomAttrTypeRequest::evaluate(Evaluator &eval, CustomAttr *attr,
 
   OpenUnboundGenericTypeFn unboundTyOpener = nullptr;
   // Property delegates allow their type to be an unbound generic.
-  if (typeKind == CustomAttrTypeKind::PropertyDelegate) {
+  if (typeKind == CustomAttrTypeKind::PropertyWrapper) {
     unboundTyOpener = [](auto unboundTy) {
       // FIXME: Don't let unbound generic types
       // escape type resolution. For now, just

test/ModuleInterface/actor_isolation.swift

@@ -0,0 +1,44 @@
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -emit-module -o %t/Test.swiftmodule -emit-module-interface-path %t/Test.swiftinterface -module-name Test -enable-experimental-concurrency %s
+// RUN: %FileCheck %s --check-prefix FROMSOURCE --check-prefix CHECK < %t/Test.swiftinterface
+// RUN: %target-swift-frontend -emit-module -o /dev/null -merge-modules %t/Test.swiftmodule -disable-objc-attr-requires-foundation-module -emit-module-interface-path %t/TestFromModule.swiftinterface -module-name Test -enable-experimental-concurrency
+// RUN: %FileCheck %s --check-prefix FROMMODULE --check-prefix CHECK < %t/TestFromModule.swiftinterface
+
+// REQUIRES: concurrency
+import _Concurrency
+
+// CHECK: actor public class SomeActor
+public actor class SomeActor {
+  @actorIndependent func maine() { }
+}
+
+// CHECK: @globalActor public struct SomeGlobalActor
+@globalActor
+public struct SomeGlobalActor {
+  public static let shared = SomeActor()
+}
+
+// CHECK: @{{(Test.)?}}SomeGlobalActor public protocol P1
+// CHECK-NEXT: @{{(Test.)?}}SomeGlobalActor func method()
+@SomeGlobalActor
+public protocol P1 {
+  func method()
+}
+
+// CHECK: class C1
+// CHECK-NEXT: @{{(Test.)?}}SomeGlobalActor public func method()
+public class C1: P1 {
+  public func method() { }
+}
+
+@SomeGlobalActor
+public class C2 { }
+
+// CHECK: @{{(Test.)?}}SomeGlobalActor public class C2
+public class C3: C2 { }
+
+// CHECK: actor public class SomeSubActor
+// CHECK-NEXT: @actorIndependent public func maine()
+public actor class SomeSubActor: SomeActor {
+  override public func maine() { }
+}