[CSDiag] Remove obsolete ambiguity code.

Author: hborla

include/swift/AST/DiagnosticsSema.def

@@ -68,9 +68,6 @@ NOTE(candidate_partial_match,none,
      "candidate has partially matching parameter list %0",
      (StringRef))
 
-ERROR(ambiguous_subscript,none,
-      "ambiguous subscript with base type %0 and index type %1",
-      (Type, Type))
 ERROR(could_not_find_value_subscript,none,
       "value of type %0 has no subscripts",
       (Type))
@@ -273,16 +270,6 @@ ERROR(no_candidates_match_result_type,none,
       "no '%0' candidates produce the expected contextual result type %1",
       (StringRef, Type))
 
-ERROR(candidates_no_match_result_type,none,
-      "'%0' produces %1, not the expected contextual result type %2",
-      (StringRef, Type, Type))
-
-
-
-ERROR(invalid_callee_result_type,none,
-      "cannot convert call result type %0 to expected type %1",
-      (Type, Type))
-
 
 ERROR(cannot_invoke_closure,none,
       "cannot invoke closure expression with an argument list of type '%0'",

lib/Sema/CSDiag.cpp

@@ -1247,17 +1247,6 @@ void FailureDiagnosis::diagnoseAmbiguity(Expr *E) {
     return;
   }
 
-  // Diagnose ".foo" expressions that lack context specifically.
-  if (auto UME =
-        dyn_cast<UnresolvedMemberExpr>(E->getSemanticsProvidingExpr())) {
-    if (!CS.getContextualType(E)) {
-      diagnose(E->getLoc(), diag::unresolved_member_no_inference,UME->getName())
-        .highlight(SourceRange(UME->getDotLoc(),
-                               UME->getNameLoc().getSourceRange().End));
-      return;
-    }
-  }
-
   // Attempt to re-type-check the entire expression, allowing ambiguity, but
   // ignoring a contextual type.
   if (expr == E) {