Merge remote-tracking branch 'apple/main' into katei/merge-main-2022-11-03

Author: kateinoigakukun

.github/CODEOWNERS

@@ -5,15 +5,40 @@
 # Owners of ASTGen
 lib/ASTGen @zoecarver @CodaFi
 
+# Dependency scanning
+include/swift/DependencyScan                 @artemcm
+lib/AST/ModuleLoader.cpp                     @artemcm
+lib/DependencyScan                           @artemcm
+lib/Frontend/ModuleInterfaceLoader.cpp       @artemcm
+lib/Serialization/SerializedModuleLoader.cpp @artemcm
+test/ScanDependencies                        @artemcm
+
+# Driver
+include/swift/Driver @artemcm
+lib/Driver           @artemcm
+test/Driver          @artemcm
+
 # Owners of the parser
 include/swift/Parse @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
 lib/Parse           @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
 test/Parse          @ahoppen @bnbarham @CodaFi @DougGregor @rintaro
 
+SwiftCompilerSources @eeckstein
+
 # C++ Interop
 include/swift/ClangImporter @zoecarver @hyp @egorzhdan
 include/swift/PrintAsClang  @zoecarver @hyp @egorzhdan
 lib/ClangImporter           @zoecarver @hyp @egorzhdan
 lib/PrintAsClang            @zoecarver @hyp @egorzhdan
 stdlib/public/Cxx           @zoecarver @hyp @egorzhdan
 test/Interop                @zoecarver @hyp @egorzhdan
+
+# Threading implementation
+include/swift/Threading @al45tair
+lib/Threading           @al45tair
+
+# Windows support
+cmake/**/*Windows*    @compnerd
+lib/Basic/Windows     @compnerd
+stdlib/public/Windows @compnerd
+utils/*windows*       @compnerd

.github/ISSUE_TEMPLATE/bug_report.md

@@ -2,30 +2,44 @@
 name: Bug report
 about: Create a report to help us improve
 title: ''
-labels: bug
+labels: bug, triage needed
 assignees: ''
 
 ---
 
-**Describe the bug**
-A clear and concise description of what the bug is.
-
-**Steps To Reproduce**
-Steps to reproduce the behavior:
-1.
-2.
-...
+<!--
+This repository tracks issues related to the implementation of the Swift
+compiler, standard library, runtime, and tools that provide IDE support for
+Swift (e.g. code completion). If the bug relates to the implementation of a
+proprietary (closed-source) Apple framework such as UIKit, SwiftUI, Combine,
+etc., please report it to https://feedbackassistant.apple.com instead.
+-->
+
+**Description**
+<!-- Describe clearly and concisely what the bug is. -->
+
+**Steps to reproduce**
+<!--
+Explain how to reproduce the problem (in steps if seen fit) and include either
+an inline test case (preferred) or a project that reproduces it. Consider
+reducing the sample to the smallest amount of code possible — a smaller test
+case is easier to reason about and more appealing to сontributors.
+-->
 
 **Expected behavior**
-A clear and concise description of what you expected to happen.
-
-**Screenshots**
-If applicable, add screenshots to help explain your problem.
-
-**Environment (please fill out the following information)**
- - OS: [e.g. macOS 11.0]
- - Xcode Version/Tag/Branch:
-
-
-**Additional context**
-Add any other context about the problem here.
+<!-- Describe what you expected to happen. -->
+
+<!-- If deemed helpful, add screenshots that showcase the problem. -->
+<!-- **Screenshots** -->
+
+<!--
+Include information about the Swift compiler version and, if applicable, the
+Xcode version you are observing the problem in and the deployment target.
+-->
+**Environment**
+- Swift compiler version info <!-- replace with the output of 'swiftc -version' -->
+- Xcode version info <!-- replace with the output of 'xcodebuild -version' -->
+- Deployment target: <!-- e.g. iOS 12.3 -->
+
+<!-- Add any other context about the problem as appropriate. -->
+<!-- **Additional context** -->

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,20 +1,49 @@
 ---
 name: Feature request
-about: Suggest an idea for this project
+about: Share an idea
 title: ''
-labels: New Feature
+labels: feature request, triage needed
 assignees: ''
 
 ---
 
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+<!--
+This repository tracks issues and requests related to the implementation of the
+Swift compiler, standard library, runtime, and tools that provide IDE support
+for Swift (e.g. code completion). If your feature request relates to the
+implementation of a proprietary (closed-source) Apple framework such as UIKit,
+SwiftUI, Combine, etc., please report it to https://feedbackassistant.apple.com
+instead.
 
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
+If you haven't found or started a thread on the Swift forums yet, consider
+socializing your idea in the "Discussion" subcategory
+(https://forums.swift.org/c/evolution/discuss) after submitting this request.
+This is an essential step toward the official review of any proposal concerning
+language or library design, and while GitHub issues do great for tracking
+purposes, the forums are far better ground for drawing attention to ideas and
+gauging interest from the community.
 
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
+For more information on how ideas are proposed, discussed, and reviewed, see
+https://swift.org/swift-evolution
+-->
 
-**Additional context**
-Add any other context or screenshots about the feature request here.
+**Motivation**
+<!-- Describe the problem that your feature seeks to address. -->
+
+**Solution**
+<!--
+Describe your solution to the problem. Provide examples and describe how
+they work.
+-->
+
+**Alternatives considered**
+<!--
+Describe any alternative approaches or features that you have considered in
+addressing the problem, and why you chose this approach instead.
+-->
+
+<!--
+Add any other context about your feature as appropriate. For example, link out
+to a discussion on the Swift forums (https://forums.swift.org).
+-->
+<!-- **Additional context** -->

CHANGELOG.md

@@ -4,6 +4,32 @@ _**Note:** This is in reverse chronological order, so newer entries are added to
 
 ## Swift 5.8
 
+* [#56139][]:
+
+  Сollection downcasts in cast patterns are now supported. For example:
+
+  ```swift
+  func collectionDowncast(_ arr: [Any]) {
+    switch arr {
+    case let ints as [Int]:
+      // ...
+    case is [Bool]:
+      // ...
+    }
+  }
+  ``` 
+* [SE-0370][]:
+
+  The API of `UnsafeMutableRawPointer`, `UnsafeMutableBufferPointer`, `UnsafeMutableRawBufferPointer` were improved, adding previously missing initialization (and deinitialization) methods, including more performant initialization from `Collection` types.
+
+  For `UnsafeMutablePointer<T>` and `UnsafeMutableBufferPointer<T>`, method names containing the word "assign" were renamed to use the word "update", and many more were added. Every multi-element initialization method of `UnsafeMutablePointer` and `UnsafeMutableBufferPointer` now has a corresponding "update" method.
+
+  Slices of `UnsafeBufferPointer`, `UnsafeRawBufferPointer`, `UnsafeMutableBufferPointer` and `UnsafeMutableRawBufferPointer` now share the collection-like API of their base type. For example, given an initialized `b: UnsafeMutableBufferPointer<Int>`, the following lines are synonymous:
+  ```swift
+  b.update(repeating: 0)
+  b[b.startIndex..<b.endIndex].update(repeating: 0)
+  ```
+
 * [SE-0365][]:
 
   Implicit `self` is now permitted for `weak self` captures, after `self` is unwrapped.
@@ -9584,6 +9610,7 @@ using the `.dynamicType` member to retrieve the type of an expression should mig
 [SE-0358]: <https://github.com/apple/swift-evolution/blob/main/proposals/0358-primary-associated-types-in-stdlib.md>
 [SE-0362]: <https://github.com/apple/swift-evolution/blob/main/proposals/0362-piecemeal-future-features.md>
 [SE-0365]: <https://github.com/apple/swift-evolution/blob/main/proposals/0365-implicit-self-weak-capture.md>
+[SE-0370]: <https://github.com/apple/swift-evolution/blob/main/proposals/0370-pointer-family-initialization-improvements.md>
 
 [#42697]: <https://github.com/apple/swift/issues/42697>
 [#42728]: <https://github.com/apple/swift/issues/42728>
@@ -9624,3 +9651,4 @@ using the `.dynamicType` member to retrieve the type of an expression should mig
 [#54246]: <https://github.com/apple/swift/issues/54246>
 [#57081]: <https://github.com/apple/swift/issues/57081>
 [#57225]: <https://github.com/apple/swift/issues/57225>
+[#56139]: <https://github.com/apple/swift/issues/56139>

CMakeLists.txt

@@ -1176,7 +1176,7 @@ endif()
 # declares the swift-stdlib-* set of targets. These targets will then
 # implicitly depend on any targets declared with IS_STDLIB.
 #
-# https://bugs.swift.org/browse/SR-5975
+# https://github.com/apple/swift/issues/48534
 if(SWIFT_BUILD_STDLIB)
   add_subdirectory(stdlib)
 else()
@@ -1216,7 +1216,7 @@ if(SWIFT_INCLUDE_TOOLS)
 
   # Always include this after including stdlib/!
   # Refer to the large comment above the add_subdirectory(stdlib) call.
-  # https://bugs.swift.org/browse/SR-5975
+  # https://github.com/apple/swift/issues/48534
   add_subdirectory(tools)
 
   # Localization targets are configured in a way that assume the swift

SwiftCompilerSources/CMakeLists.txt

@@ -16,7 +16,7 @@
 #
 function(add_swift_compiler_module module)
   cmake_parse_arguments(ALSM
-                        "ADD_TO_SYNTAXPARSE"
+                        ""
                         ""
                         "DEPENDS;SOURCES"
                         ${ARGN})
@@ -35,7 +35,6 @@ function(add_swift_compiler_module module)
 
   set_property(TARGET ${target_name} PROPERTY module_name ${module})
   set_property(TARGET ${target_name} PROPERTY module_depends ${ALSM_DEPENDS})
-  set_property(TARGET ${target_name} PROPERTY add_to_syntaxparse ${ALSM_ADD_TO_SYNTAXPARSE})
 
   get_property(modules GLOBAL PROPERTY swift_compiler_modules)
   set_property(GLOBAL PROPERTY swift_compiler_modules ${modules} ${module})
@@ -134,16 +133,13 @@ function(add_swift_compiler_modules_library name)
 
   set(all_obj_files)
   set(all_module_targets)
-  set(syntaxparse_obj_files)
-  set(syntaxparse_module_targets)
   get_property(modules GLOBAL PROPERTY "swift_compiler_modules")
   foreach(module ${modules})
 
     set(module_target "SwiftModule${module}")
     get_target_property(module ${module_target} "module_name")
     get_target_property(sources ${module_target} SOURCES)
     get_target_property(dependencies ${module_target} "module_depends")
-    get_target_property(add_to_syntaxparse ${module_target} "add_to_syntaxparse")
     set(deps, "")
     if (dependencies)
       foreach(dep_module ${dependencies})
@@ -163,9 +159,6 @@ function(add_swift_compiler_modules_library name)
     set_property(TARGET ${module_target} PROPERTY "module_file" "${module_file}")
 
     set(all_obj_files ${all_obj_files} ${module_obj_file})
-    if (add_to_syntaxparse)
-      set(syntaxparse_obj_files ${syntaxparse_obj_files} ${module_obj_file})
-    endif()
     set(c_include_paths
       # LLVM modules and headers.
       "${LLVM_MAIN_INCLUDE_DIR}"
@@ -201,9 +194,6 @@ function(add_swift_compiler_modules_library name)
 
     set("${module}_dep_target" ${dep_target})
     set(all_module_targets ${all_module_targets} ${dep_target})
-    if (add_to_syntaxparse)
-      set(syntaxparse_module_targets ${syntaxparse_module_targets} ${dep_target})
-    endif()
   endforeach()
 
   # Create a static library containing all module object files.
@@ -217,15 +207,6 @@ function(add_swift_compiler_modules_library name)
   add_dependencies(${name} ${all_module_targets})
   set_target_properties(${name} PROPERTIES LINKER_LANGUAGE CXX)
   set_property(GLOBAL APPEND PROPERTY SWIFT_BUILDTREE_EXPORTS ${name})
-
-  if (XCODE)
-    set(syntaxparse_obj_files force_lib.c ${syntaxparse_obj_files})
-  endif()
-  add_library("${name}_SwiftSyntax" STATIC ${syntaxparse_obj_files})
-  add_dependencies("${name}_SwiftSyntax" ${syntaxparse_module_targets})
-  set_target_properties("${name}_SwiftSyntax" PROPERTIES LINKER_LANGUAGE CXX)
-  set_property(GLOBAL APPEND PROPERTY SWIFT_BUILDTREE_EXPORTS "${name}_SwiftSyntax")
-
 endfunction()
 
 
@@ -235,7 +216,6 @@ add_swift_host_library(swiftCompilerStub OBJECT stubs.cpp)
 if (NOT BOOTSTRAPPING_MODE)
 
   add_library(swiftCompilerModules ALIAS swiftCompilerStub)
-  add_library(swiftCompilerModules_SwiftSyntax ALIAS swiftCompilerStub)
 
 else()
   # Note: "Swift" is not added intentionally here, because it would break

SwiftCompilerSources/Sources/AST/CMakeLists.txt

@@ -7,7 +7,6 @@
 # See http://swift.org/CONTRIBUTORS.txt for Swift project authors
 
 add_swift_compiler_module(AST
-  ADD_TO_SYNTAXPARSE
   DEPENDS
     Basic
   SOURCES

SwiftCompilerSources/Sources/Basic/CMakeLists.txt

@@ -7,7 +7,6 @@
 # See http://swift.org/CONTRIBUTORS.txt for Swift project authors
 
 add_swift_compiler_module(Basic
-  ADD_TO_SYNTAXPARSE
   SOURCES
     SourceLoc.swift
     Utils.swift)

SwiftCompilerSources/Sources/Basic/Utils.swift

@@ -11,7 +11,7 @@
 //===----------------------------------------------------------------------===//
 
 @_exported import BasicBridging
-import std
+import CxxStdlib
 
 /// The assert function to be used in the compiler.
 ///

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ComputeSideEffects.swift

@@ -463,7 +463,7 @@ private extension PartialApplyInst {
     struct EscapesToApply : EscapeVisitor {
       func visitUse(operand: Operand, path: EscapePath) -> UseResult {
         switch operand.instruction {
-        case is ApplySite:
+        case is FullApplySite:
           // Any escape to apply - regardless if it's an argument or the callee operand - might cause
           // the closure to be called.
           return .abort