Tighten condition under which we bailout from lifetime dependence inference of implicit functions

meg-gupta · meg-gupta · commit afdfd2e6142a · 2024-03-06T21:57:02.000-08:00
diff --git a/lib/Sema/LifetimeDependence.cpp b/lib/Sema/LifetimeDependence.cpp
@@ -379,7 +379,7 @@ LifetimeDependenceInfo::infer(AbstractFunctionDecl *afd, Type resultType) {
     // TODO: rdar://123555720: Remove this check after another round of
     // surveying builtins
     if (auto *fd = dyn_cast<FuncDecl>(afd)) {
-      if (fd->isImplicit()) {
+      if (fd->isImplicit() && fd->getModuleContext()->isBuiltinModule()) {
         return std::nullopt;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,7 @@ LifetimeDependenceInfo::infer(AbstractFunctionDecl *afd, Type resultType) {`
`379`	`379`	`// TODO: rdar://123555720: Remove this check after another round of`
`380`	`380`	`// surveying builtins`
`381`	`381`	`if (auto *fd = dyn_cast<FuncDecl>(afd)) {`
`382`		`- if (fd->isImplicit()) {`
	`382`	`+ if (fd->isImplicit() && fd->getModuleContext()->isBuiltinModule()) {`
`383`	`383`	`return std::nullopt;`
`384`	`384`	`}`
`385`	`385`	`}`