Merge pull request swiftlang#40209 from kubamracek/ndebug-vs-assert

Add #ifndef NDEBUG around assert() calls that use helper functions/variables that are also under #ifndef NDEBUG

Author: kubamracek

stdlib/public/runtime/Metadata.cpp

@@ -3262,7 +3262,9 @@ swift::swift_lookUpClassMethod(const ClassMetadata *metadata,
                                const ClassDescriptor *description) {
   assert(metadata->isTypeMetadata());
 
+#ifndef NDEBUG
   assert(isAncestorOf(metadata, description));
+#endif
 
   auto *vtable = description->getVTableDescriptor();
   assert(vtable != nullptr);
@@ -4021,9 +4023,11 @@ swift::swift_getExistentialTypeMetadata(
 
   // Ensure that the "class constraint" bit is set whenever we have a
   // superclass or a one of the protocols is class-bound.
+#ifndef NDEBUG
   assert(classConstraint == ProtocolClassConstraint::Class ||
          (!superclassConstraint &&
           !anyProtocolIsClassBound(numProtocols, protocols)));
+#endif
   ExistentialCacheEntry::Key key = {
     superclassConstraint, classConstraint, (uint32_t)numProtocols, protocols
   };

stdlib/public/runtime/MetadataLookup.cpp

@@ -429,7 +429,9 @@ ParsedTypeIdentity::parse(const TypeContextDescriptor *type) {
     result.ImportInfo->collect</*asserting*/true>(component);
   }
 
+#ifndef NDEBUG
   assert(stage != AfterName && "no components?");
+#endif
 
   // Record the full identity.
   result.FullIdentity =