Make string_set_dispose method a part of public API.

It is not a distinct result returned by `swiftscan_compiler_supported_arguments_query` and `swiftscan_compiler_supported_features_query`, not owned by any other type, so it must be disposed of by the clients.

Author: artemcm

include/swift-c/DependencyScan/DependencyScan.h

@@ -274,6 +274,9 @@ swiftscan_scan_invocation_get_argv(swiftscan_scan_invocation_t invocation);
 
 //=== Cleanup Functions ---------------------------------------------------===//
 
+SWIFTSCAN_PUBLIC void
+swiftscan_string_set_dispose(swiftscan_string_set_t *set);
+
 SWIFTSCAN_PUBLIC void
 swiftscan_dependency_graph_dispose(swiftscan_dependency_graph_t result);
 

tools/libSwiftScan/libSwiftScan.cpp

@@ -32,14 +32,6 @@ void swiftscan_string_dispose(swiftscan_string_ref_t string) {
     free(const_cast<void *>(string.data));
 }
 
-/// Free the given string set.
-void swiftscan_string_set_dispose(swiftscan_string_set_t *set) {
-  for (unsigned SI = 0, SE = set->count; SI < SE; ++SI)
-    swiftscan_string_dispose(set->strings[SI]);
-  delete[] set->strings;
-  delete set;
-}
-
 void swiftscan_dependency_info_details_dispose(
     swiftscan_module_details_t details) {
   swiftscan_module_details_s *details_impl = details;
@@ -423,6 +415,13 @@ swiftscan_scan_invocation_get_argv(swiftscan_scan_invocation_t invocation) {
 
 //=== Public Cleanup Functions --------------------------------------------===//
 
+void swiftscan_string_set_dispose(swiftscan_string_set_t *set) {
+  for (unsigned SI = 0, SE = set->count; SI < SE; ++SI)
+    swiftscan_string_dispose(set->strings[SI]);
+  delete[] set->strings;
+  delete set;
+}
+
 void swiftscan_dependency_graph_dispose(swiftscan_dependency_graph_t result) {
   swiftscan_string_dispose(result->main_module_name);
   swiftscan_dependency_set_dispose(result->dependencies);

tools/libSwiftScan/libSwiftScan.exports

@@ -44,6 +44,7 @@ swiftscan_dependency_graph_create
 swiftscan_batch_scan_result_create
 swiftscan_import_set_create
 swiftscan_scanner_create
+swiftscan_string_set_dispose
 swiftscan_scan_invocation_dispose
 swiftscan_batch_scan_input_dispose
 swiftscan_batch_scan_entry_dispose

unittests/DependencyScan/Features.cpp

@@ -44,6 +44,7 @@ TEST_F(ScanTest, TestHasArgumentQuery) {
     const char* data = static_cast<const char*>(option.data);
     optionSet.insert(std::string(data, option.length));
   }
+  swiftscan_string_set_dispose(supported_args_set);
 #define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM,  \
                HELPTEXT, METAVAR, VALUES)                                      \
   testHasOption(*table, swift::options::OPT_##ID, optionSet);
@@ -59,6 +60,7 @@ TEST_F(ScanTest, TestDoesNotHaveArgumentQuery) {
     const char* data = static_cast<const char*>(option.data);
     optionSet.insert(std::string(data, option.length));
   }
+  swiftscan_string_set_dispose(supported_args_set);
   bool hasOption;
   hasOption = optionSet.find("-clearly-not-a-compiler-flag") != optionSet.end();
   EXPECT_EQ(hasOption, false);