Update code as per Apple Style Guide

whitelist -> allowlist
blacklist -> denylist

Author: meg-gupta

docs/Testing.md

@@ -572,17 +572,17 @@ If you're specifically testing the autoreleasing behavior of code, or do not
 expect code to interact with the Objective-C runtime, it may be OK to use ``if
 true {}``, but those assumptions should be commented in the test.
 
-#### Enabling/disabling the lldb test whitelist
+#### Enabling/disabling the lldb test allowlist
 
-It's possible to enable a whitelist of swift-specific lldb tests to run during
+It's possible to enable a allowlist of swift-specific lldb tests to run during
 PR smoke testing. Note that the default set of tests which run (which includes
-tests not in the whitelist) already only includes swift-specific tests.
+tests not in the allowlist) already only includes swift-specific tests.
 
-Enabling the whitelist is an option of last-resort to unblock swift PR testing
+Enabling the allowlist is an option of last-resort to unblock swift PR testing
 in the event that lldb test failures cannot be resolved in a timely way. If
-this becomes necessary, be sure to double-check that enabling the whitelist
+this becomes necessary, be sure to double-check that enabling the allowlist
 actually unblocks PR testing by running the smoke test build preset locally.
 
-To enable the lldb test whitelist, add `-G swiftpr` to the
+To enable the lldb test allowlist, add `-G swiftpr` to the
 `LLDB_TEST_CATEGORIES` variable in `utils/build-script-impl`. Disable it by
 removing that option.

lib/IRGen/GenDecl.cpp

@@ -2111,9 +2111,9 @@ swift::irgen::createLinkerDirectiveVariable(IRGenModule &IGM, StringRef name) {
 }
 
 void swift::irgen::disableAddressSanitizer(IRGenModule &IGM, llvm::GlobalVariable *var) {
-  // Add an operand to llvm.asan.globals blacklisting this global variable.
+  // Add an operand to llvm.asan.globals denylisting this global variable.
   llvm::Metadata *metadata[] = {
-    // The global variable to blacklist.
+    // The global variable to denylist.
     llvm::ConstantAsMetadata::get(var),
 
     // Source location. Optional, unnecessary here.
@@ -2126,7 +2126,7 @@ void swift::irgen::disableAddressSanitizer(IRGenModule &IGM, llvm::GlobalVariabl
     llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
       llvm::Type::getInt1Ty(IGM.Module.getContext()), false)),
 
-    // Whether the global is blacklisted.
+    // Whether the global is denylisted.
     llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
       llvm::Type::getInt1Ty(IGM.Module.getContext()), true))};
 

lib/SIL/Utils/MemAccessUtils.cpp

@@ -509,7 +509,7 @@ bool swift::isSingleInitAllocStack(AllocStackInst *asi,
       continue;
     }
 
-    // Otherwise, if we have found something not in our whitelist, return false.
+    // Otherwise, if we have found something not in our allowlist, return false.
     return false;
   }
 

lib/SIL/Verifier/SILVerifier.cpp

@@ -1936,13 +1936,13 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
     }
 
     // Verify that all formal accesses patterns are recognized as part of a
-    // whitelist. The presence of an unknown pattern means that analysis will
+    // allowlist. The presence of an unknown pattern means that analysis will
     // silently fail, and the compiler may be introducing undefined behavior
     // with no other way to detect it.
     //
     // For example, AccessEnforcementWMO runs very late in the
     // pipeline and assumes valid storage for all dynamic Read/Modify access. It
-    // also requires that Unidentified access fit a whitelist on known
+    // also requires that Unidentified access fit a allowlist on known
     // non-internal globals or class properties.
     //
     // First check that identifyFormalAccess returns without asserting. For

lib/SILOptimizer/Mandatory/DiagnoseStaticExclusivity.cpp

@@ -1019,7 +1019,7 @@ static void checkAccessedAddress(Operand *memOper, StorageMap &Accesses) {
 
   const AccessedStorage &storage = findAccessedStorage(address);
   // findAccessedStorage may return an invalid storage object if the address
-  // producer is not recognized by its whitelist. For the purpose of
+  // producer is not recognized by its allowlist. For the purpose of
   // verification, we assume that this can only happen for local
   // initialization, not a formal memory access. The strength of
   // verification rests on the completeness of the opcode list inside

lib/SILOptimizer/Transforms/CopyForwarding.cpp

@@ -200,7 +200,7 @@ class AddressUserVisitor {
 
 /// Gather all instructions that use the given `address`
 ///
-/// "Normal" uses are a whitelisted set of uses that guarantees the address is
+/// "Normal" uses are a allowlisted set of uses that guarantees the address is
 /// only used as if it refers to a single value and all uses are accounted for
 /// (no address projections).
 ///

lib/SILOptimizer/Transforms/TempRValueElimination.cpp

@@ -419,7 +419,7 @@ bool TempRValueOptPass::checkTempObjectDestroy(
       return false;
 
     // Look for a known destroy point as described in the function level
-    // comment. This whitelist can be expanded as more cases are handled in
+    // comment. This allowlist can be expanded as more cases are handled in
     // tryOptimizeCopyIntoTemp during copy replacement.
     SILInstruction *lastUser = &*std::prev(pos);
     if (isa<DestroyAddrInst>(lastUser))

test/IRGen/ELF-remove-autolink-section.swift

@@ -14,7 +14,7 @@ print("Hi from Swift!")
 
 // ELF: module asm ".section .swift1_autolink_entries,\220x80000000\22"
 
-// Find the metadata entry for the blacklisting of the metadata symbol
+// Find the metadata entry for the denylisting of the metadata symbol
 // Ensure that it is in the ASAN metadata
 
 // ELF-DAG: !llvm.asan.globals = !{

test/api-digester/Inputs/Foo-prot-whitelist.txt renamed to test/api-digester/Inputs/Foo-prot-allowlist.txt

@@ -3,7 +3,7 @@
 // RUN: %empty-directory(%t.module-cache)
 // RUN: %api-digester -dump-sdk -module Foo -o %t.dump1.json -module-cache-path %t.module-cache %clang-importer-sdk-nosource -I %S/Inputs/Foo -avoid-location
 // RUN: %api-digester -dump-sdk -module Foo -o %t.dump2.json -module-cache-path %t.module-cache %clang-importer-sdk-nosource -I %S/Inputs/Foo-new-version -avoid-location
-// RUN: %api-digester -diagnose-sdk -protocol-requirement-white-list %S/Inputs/Foo-prot-whitelist.txt -print-module --input-paths %t.dump1.json -input-paths %t.dump2.json -o %t.result
+// RUN: %api-digester -diagnose-sdk -protocol-requirement-white-list %S/Inputs/Foo-prot-allowlist.txt -print-module --input-paths %t.dump1.json -input-paths %t.dump2.json -o %t.result
 
 // RUN: %clang -E -P -x c %S/Outputs/Foo-diff.txt -o - | sed '/^\s*$/d' > %t.expected
 // RUN: %clang -E -P -x c %t.result -o - | sed '/^\s*$/d' > %t.result.tmp