Merge pull request swiftlang#18991 from rjmccall/loop-can-duplicate-begin-apply

Update SILLoop::canDuplicate to correctly handle begin_apply

Author: rjmccall

lib/SIL/LoopInfo.cpp

@@ -78,6 +78,20 @@ bool SILLoop::canDuplicate(SILInstruction *I) const {
     return false;
   }
 
+  // The entire coroutine execution must be within the loop.
+  // Note that we don't have to worry about the reverse --- a loop which
+  // contains an end_apply or abort_apply of an external begin_apply ---
+  // because that wouldn't be structurally valid in the first place.
+  if (auto BAI = dyn_cast<BeginApplyInst>(I)) {
+    for (auto UI : BAI->getTokenResult()->getUses()) {
+      auto User = UI->getUser();
+      assert(isa<EndApplyInst>(User) || isa<AbortApplyInst>(User));
+      if (!contains(User))
+        return false;
+    }
+    return true;
+  }
+
   if (isa<ThrowInst>(I))
     return false;
 

lib/SIL/SILInstruction.cpp

@@ -1178,6 +1178,8 @@ bool SILInstruction::isTriviallyDuplicatable() const {
   if (isa<BeginApplyInst>(this))
     return false;
 
+  // If you add more cases here, you should also update SILLoop:canDuplicate.
+
   return true;
 }