[ConstraintSystem] NFC: Move implementation of PotentialBindings::dump(...) into cpp

Author: xedin

include/swift/Sema/ConstraintSystem.h

@@ -4964,79 +4964,10 @@ class ConstraintSystem {
                       &inferredBindings);
 
     void dump(llvm::raw_ostream &out,
-              unsigned indent = 0) const LLVM_ATTRIBUTE_USED {
-      out.indent(indent);
-      if (isDirectHole())
-        out << "hole ";
-      if (isPotentiallyIncomplete())
-        out << "potentially_incomplete ";
-      if (isDelayed())
-        out << "delayed ";
-      if (isSubtypeOfExistentialType())
-        out << "subtype_of_existential ";
-      auto literalKind = getLiteralKind();
-      if (literalKind != inference::LiteralBindingKind::None)
-        out << "literal=" << static_cast<int>(literalKind) << " ";
-      if (involvesTypeVariables())
-        out << "involves_type_vars ";
-
-      auto numDefaultable = getNumViableDefaultableBindings();
-      if (numDefaultable > 0)
-        out << "#defaultable_bindings=" << numDefaultable << " ";
-
-      PrintOptions PO;
-      PO.PrintTypesForDebugging = true;
-
-      auto printBinding = [&](const inference::PotentialBinding &binding) {
-        auto type = binding.BindingType;
-        switch (binding.Kind) {
-        case inference::AllowedBindingKind::Exact:
-          break;
-
-        case inference::AllowedBindingKind::Subtypes:
-          out << "(subtypes of) ";
-          break;
-
-        case inference::AllowedBindingKind::Supertypes:
-          out << "(supertypes of) ";
-          break;
-        }
-        if (auto *literal = binding.getDefaultedLiteralProtocol())
-          out << "(default from " << literal->getName() << ") ";
-        out << type.getString(PO);
-      };
-
-      out << "bindings={";
-      interleave(Bindings, printBinding, [&]() { out << "; "; });
-      out << "}";
-
-      if (!Defaults.empty()) {
-        out << " defaults={";
-        for (const auto &entry : Defaults) {
-          auto *constraint = entry.second;
-          inference::PotentialBinding binding{
-              constraint->getSecondType(), inference::AllowedBindingKind::Exact,
-              constraint};
-          printBinding(binding);
-        }
-        out << "}";
-      }
-    }
-
-    void dump(ConstraintSystem *cs,
-              unsigned indent = 0) const LLVM_ATTRIBUTE_USED {
-      dump(llvm::errs());
-    }
+              unsigned indent = 0) const LLVM_ATTRIBUTE_USED;
 
     void dump(TypeVariableType *typeVar, llvm::raw_ostream &out,
-              unsigned indent = 0) const LLVM_ATTRIBUTE_USED {
-      out.indent(indent);
-      out << "(";
-      if (typeVar)
-        out << "$T" << typeVar->getImpl().getID();
-      dump(out, 1);
-      out << ")\n";
-    }
+              unsigned indent = 0) const LLVM_ATTRIBUTE_USED;
   };
 
   Optional<Type> checkTypeOfBinding(TypeVariableType *typeVar, Type type) const;

lib/Sema/CSBindings.cpp

@@ -18,6 +18,7 @@
 #include "swift/Sema/ConstraintGraph.h"
 #include "swift/Sema/ConstraintSystem.h"
 #include "llvm/ADT/SetVector.h"
+#include "llvm/Support/raw_ostream.h"
 #include <tuple>
 
 using namespace swift;
@@ -1232,6 +1233,76 @@ ConstraintSystem::PotentialBindings::getNumViableLiteralBindings() const {
   });
 }
 
+void ConstraintSystem::PotentialBindings::dump(TypeVariableType *typeVar,
+                                               llvm::raw_ostream &out,
+                                               unsigned indent) const {
+  out.indent(indent);
+  out << "(";
+  if (typeVar)
+    out << "$T" << typeVar->getImpl().getID();
+  dump(out, 1);
+  out << ")\n";
+}
+
+void ConstraintSystem::PotentialBindings::dump(llvm::raw_ostream &out,
+                                               unsigned indent) const {
+  out.indent(indent);
+  if (isDirectHole())
+    out << "hole ";
+  if (isPotentiallyIncomplete())
+    out << "potentially_incomplete ";
+  if (isDelayed())
+    out << "delayed ";
+  if (isSubtypeOfExistentialType())
+    out << "subtype_of_existential ";
+  auto literalKind = getLiteralKind();
+  if (literalKind != inference::LiteralBindingKind::None)
+    out << "literal=" << static_cast<int>(literalKind) << " ";
+  if (involvesTypeVariables())
+    out << "involves_type_vars ";
+
+  auto numDefaultable = getNumViableDefaultableBindings();
+  if (numDefaultable > 0)
+    out << "#defaultable_bindings=" << numDefaultable << " ";
+
+  PrintOptions PO;
+  PO.PrintTypesForDebugging = true;
+
+  auto printBinding = [&](const PotentialBinding &binding) {
+    auto type = binding.BindingType;
+    switch (binding.Kind) {
+    case AllowedBindingKind::Exact:
+      break;
+
+    case AllowedBindingKind::Subtypes:
+      out << "(subtypes of) ";
+      break;
+
+    case AllowedBindingKind::Supertypes:
+      out << "(supertypes of) ";
+      break;
+    }
+    if (auto *literal = binding.getDefaultedLiteralProtocol())
+      out << "(default from " << literal->getName() << ") ";
+    out << type.getString(PO);
+  };
+
+  out << "bindings={";
+  interleave(Bindings, printBinding, [&]() { out << "; "; });
+  out << "}";
+
+  if (!Defaults.empty()) {
+    out << " defaults={";
+    for (const auto &entry : Defaults) {
+      auto *constraint = entry.second;
+      PotentialBinding binding{constraint->getSecondType(),
+                               AllowedBindingKind::Exact, constraint};
+      printBinding(binding);
+    }
+    out << "}";
+  }
+}
+
 /// Check whether the given type can be used as a binding for the given
 /// type variable.
 ///