Merge pull request swiftlang#19797 from eeckstein/remove-dead-bridging-calls

Author: swift-ci

lib/IRGen/IRGenModule.cpp

@@ -711,6 +711,12 @@ bool IRGenerator::canEmitWitnessTableLazily(SILWitnessTable *wt) {
   if (Opts.UseJIT)
     return false;
 
+  // Regardless of the access level, if the witness table is shared it means
+  // we can safely not emit it. Every other module which needs it will generate
+  // its own shared copy of it.
+  if (wt->getLinkage() == SILLinkage::Shared)
+    return true;
+
   NominalTypeDecl *ConformingTy =
     wt->getConformance()->getType()->getNominalOrBoundGenericNominal();
 

stdlib/public/SDK/Dispatch/Data.swift

@@ -356,6 +356,7 @@ extension DispatchData {
 		return true
 	}
 
+	@_effects(readonly)
 	public static func _unconditionallyBridgeFromObjectiveC(_ source: __DispatchData?) -> DispatchData {
 		var result: DispatchData?
 		_forceBridgeFromObjectiveC(source!, result: &result)

stdlib/public/SDK/Foundation/AffineTransform.swift

@@ -317,6 +317,7 @@ extension AffineTransform : _ObjectiveCBridgeable {
         return true // Can't fail
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ x: NSAffineTransform?) -> AffineTransform {
         guard let src = x else { return AffineTransform.identity }
         return AffineTransform(reference: src)

stdlib/public/SDK/Foundation/Calendar.swift

@@ -1113,6 +1113,7 @@ extension Calendar : _ObjectiveCBridgeable {
         return true
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSCalendar?) -> Calendar {
         var result: Calendar?
         _forceBridgeFromObjectiveC(source!, result: &result)

stdlib/public/SDK/Foundation/CharacterSet.swift

@@ -782,6 +782,7 @@ extension CharacterSet : _ObjectiveCBridgeable {
         return true
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSCharacterSet?) -> CharacterSet {
         guard let src = source else { return CharacterSet() }
         return CharacterSet(_bridged: src)

stdlib/public/SDK/Foundation/Data.swift

@@ -1902,7 +1902,8 @@ extension Data : _ObjectiveCBridgeable {
         result = Data(referencing: input)
         return true
     }
-    
+
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSData?) -> Data {
         guard let src = source else { return Data() }
         return Data(referencing: src)

stdlib/public/SDK/Foundation/Date.swift

@@ -257,6 +257,7 @@ extension Date : _ObjectiveCBridgeable {
         return true
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSDate?) -> Date {
         var result: Date?
         _forceBridgeFromObjectiveC(source!, result: &result)

stdlib/public/SDK/Foundation/DateComponents.swift

@@ -338,6 +338,7 @@ extension DateComponents : _ObjectiveCBridgeable {
         return true
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSDateComponents?) -> DateComponents {
         guard let src = source else { return DateComponents() }
         return DateComponents(reference: src)

stdlib/public/SDK/Foundation/DateInterval.swift

@@ -216,6 +216,7 @@ extension DateInterval : _ObjectiveCBridgeable {
         return true
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSDateInterval?) -> DateInterval {
         var result: DateInterval?
         _forceBridgeFromObjectiveC(source!, result: &result)

stdlib/public/SDK/Foundation/Decimal.swift

@@ -487,6 +487,7 @@ extension Decimal : _ObjectiveCBridgeable {
         return true
     }
 
+    @_effects(readonly)
     public static func _unconditionallyBridgeFromObjectiveC(_ source: NSDecimalNumber?) -> Decimal {
         guard let src = source else { return Decimal(_exponent: 0, _length: 0, _isNegative: 0, _isCompact: 0, _reserved: 0, _mantissa: (0, 0, 0, 0, 0, 0, 0, 0)) }
         return src.decimalValue