Only emit @unsafe warning when strict safety mode is enabled

DougGregor · DougGregor · commit b6e995e7d95f · 2024-12-20T23:15:42.000-08:00
diff --git a/lib/Sema/TypeCheckAvailability.cpp b/lib/Sema/TypeCheckAvailability.cpp
@@ -4769,7 +4769,8 @@ swift::diagnoseConformanceAvailability(SourceLoc loc,
   }
 
   // Strict memory safety checking.
-  if (!where.getAvailability().allowsUnsafe()) {
+  if (!where.getAvailability().allowsUnsafe() &&
+      ctx.LangOpts.hasFeature(Feature::WarnUnsafe)) {
     if (auto normalConf = dyn_cast<NormalProtocolConformance>(rootConf)) {
       // @unchecked Sendable conformances are considered unsafe when complete
       // checking is enabled.

Original file line number	Diff line number	Diff line change
`@@ -4769,7 +4769,8 @@ swift::diagnoseConformanceAvailability(SourceLoc loc,`
`4769`	`4769`	`}`
`4770`	`4770`
`4771`	`4771`	`// Strict memory safety checking.`
`4772`		`- if (!where.getAvailability().allowsUnsafe()) {`
	`4772`	`+ if (!where.getAvailability().allowsUnsafe() &&`
	`4773`	`+ ctx.LangOpts.hasFeature(Feature::WarnUnsafe)) {`
`4773`	`4774`	`if (auto normalConf = dyn_cast<NormalProtocolConformance>(rootConf)) {`
`4774`	`4775`	`// @unchecked Sendable conformances are considered unsafe when complete`
`4775`	`4776`	`// checking is enabled.`