Merge pull request swiftlang#35963 from zoecarver/cxx/bail-on-large-templates

[cxx-interop] Bail on deep template specializations.

Author: zoecarver

lib/ClangImporter/ImportDecl.cpp

@@ -3698,6 +3698,22 @@ namespace {
       return VisitRecordDecl(decl);
     }
 
+    bool isSpecializationDepthGreaterThan(
+        const clang::ClassTemplateSpecializationDecl *decl, unsigned maxDepth) {
+      for (auto arg : decl->getTemplateArgs().asArray()) {
+        if (arg.getKind() == clang::TemplateArgument::Type) {
+          if (auto classSpec =
+                  dyn_cast_or_null<clang::ClassTemplateSpecializationDecl>(
+                      arg.getAsType()->getAsCXXRecordDecl())) {
+            if (maxDepth == 0 ||
+                isSpecializationDepthGreaterThan(classSpec, maxDepth - 1))
+              return true;
+          }
+        }
+      }
+      return false;
+    }
+
     Decl *VisitClassTemplateSpecializationDecl(
                  const clang::ClassTemplateSpecializationDecl *decl) {
       // `Sema::isCompleteType` will try to instantiate the class template as a
@@ -3715,6 +3731,13 @@ namespace {
           decl->getDefinition());
       assert(def && "Class template instantiation didn't have definition");
 
+      // Currently this is a relatively low number, in the future we might
+      // consider increasing it, but this should keep compile time down,
+      // especially for types that become exponentially large when
+      // instantiating.
+      if (isSpecializationDepthGreaterThan(def, 8))
+        return nullptr;
+
       // FIXME: This will instantiate all members of the specialization (and detect
       // instantiation failures in them), which can be more than is necessary
       // and is more than what Clang does. As a result we reject some C++

test/Interop/Cxx/templates/Inputs/large-class-templates.h

@@ -0,0 +1,6 @@
+template <class T>
+struct HasTypeWithSelfAsParam {
+  using TT = HasTypeWithSelfAsParam<HasTypeWithSelfAsParam<T>>;
+};
+
+using WillBeInfinite = HasTypeWithSelfAsParam<int>;

test/Interop/Cxx/templates/Inputs/module.modulemap

@@ -112,3 +112,8 @@ module MemberTemplates {
   header "member-templates.h"
   requires cplusplus
 }
+
+module LargeClassTemplates {
+  header "large-class-templates.h"
+  requires cplusplus
+}

test/Interop/Cxx/templates/large-class-templates-module-interface.swift

@@ -0,0 +1,11 @@
+// RUN: %target-swift-ide-test -print-module -module-to-print=LargeClassTemplates -I %S/Inputs -source-filename=x -enable-cxx-interop | %FileCheck %s
+
+// CHECK: struct HasTypeWithSelfAsParam<T> {
+// CHECK: }
+
+// CHECK: struct __CxxTemplateInst22HasTypeWithSelfAsParamIiE {
+// CHECK:   typealias TT = __CxxTemplateInst22HasTypeWithSelfAsParamIS_IiEE
+// CHECK:   init()
+// CHECK: }
+
+// CHECK: typealias WillBeInfinite = __CxxTemplateInst22HasTypeWithSelfAsParamIiE