Merge pull request swiftlang#36393 from apple/ClangImporter-Fix-Wcovered-switch-default-warning

kastiglione · web-flow · commit beac4a69a580 · 2021-03-13T23:42:03.000-08:00
[ClangImporter] Fix -Wcovered-switch-default warning (NFC)
diff --git a/lib/ClangImporter/ClangAdapter.cpp b/lib/ClangImporter/ClangAdapter.cpp
@@ -629,12 +629,10 @@ OptionalTypeKind importer::translateNullability(
 
   case clang::NullabilityKind::Unspecified:
     return OptionalTypeKind::OTK_ImplicitlyUnwrappedOptional;
-
-  default:
-    return OptionalTypeKind::OTK_Optional;
   }
 
   llvm_unreachable("Invalid NullabilityKind.");
+  return OptionalTypeKind::OTK_Optional;
 }
 
 bool importer::isRequiredInitializer(const clang::ObjCMethodDecl *method) {

Original file line number	Diff line number	Diff line change
`@@ -629,12 +629,10 @@ OptionalTypeKind importer::translateNullability(`
`629`	`629`
`630`	`630`	`case clang::NullabilityKind::Unspecified:`
`631`	`631`	`return OptionalTypeKind::OTK_ImplicitlyUnwrappedOptional;`
`632`		`-`
`633`		`- default:`
`634`		`- return OptionalTypeKind::OTK_Optional;`
`635`	`632`	`}`
`636`	`633`
`637`	`634`	`llvm_unreachable("Invalid NullabilityKind.");`
	`635`	`+ return OptionalTypeKind::OTK_Optional;`
`638`	`636`	`}`
`639`	`637`
`640`	`638`	`bool importer::isRequiredInitializer(const clang::ObjCMethodDecl *method) {`