Merge pull request swiftlang#80030 from DougGregor/import-macro-in-cpp-class-and-namespace

[Clang importer] Report auxiliary decls from C++ class and namespace lookup

Author: DougGregor

lib/AST/ASTPrinter.cpp

@@ -2750,8 +2750,24 @@ static void addNamespaceMembers(Decl *decl,
           auto clangMember = found.get<clang::NamedDecl *>();
           if (auto importedDecl =
                   ctx.getClangModuleLoader()->importDeclDirectly(clangMember)) {
-            if (addedMembers.insert(importedDecl).second)
+            if (addedMembers.insert(importedDecl).second) {
               members.push_back(importedDecl);
+
+              // Handle macro-expanded declarations.
+              importedDecl->visitAuxiliaryDecls([&](Decl *decl) {
+                auto valueDecl = dyn_cast<ValueDecl>(decl);
+                if (!valueDecl)
+                  return;
+
+                // Bail out if the auxiliary decl was not produced by a macro.
+                auto module = decl->getDeclContext()->getParentModule();
+                auto *sf = module->getSourceFileContainingLocation(decl->getLoc());
+                if (!sf || sf->Kind != SourceFileKind::MacroExpansion)
+                  return;
+
+                members.push_back(valueDecl);
+              });
+            }
           }
         }
       };

lib/ClangImporter/ClangImporter.cpp

@@ -5084,6 +5084,42 @@ ClangDirectLookupRequest::evaluate(Evaluator &evaluator,
   return filteredDecls;
 }
 
+namespace {
+  /// Collects name lookup results into the given tiny vector, for use in the
+  /// various Clang importer lookup routines.
+  class CollectLookupResults {
+    DeclName name;
+    TinyPtrVector<ValueDecl *> &result;
+
+  public:
+    CollectLookupResults(DeclName name, TinyPtrVector<ValueDecl *> &result)
+      : name(name), result(result) { }
+
+    void add(ValueDecl *imported) {
+      result.push_back(imported);
+
+      // Expand any macros introduced by the Clang importer.
+      imported->visitAuxiliaryDecls([&](Decl *decl) {
+        auto valueDecl = dyn_cast<ValueDecl>(decl);
+        if (!valueDecl)
+          return;
+
+        // Bail out if the auxiliary decl was not produced by a macro.
+        auto module = decl->getDeclContext()->getParentModule();
+        auto *sf = module->getSourceFileContainingLocation(decl->getLoc());
+        if (!sf || sf->Kind != SourceFileKind::MacroExpansion)
+          return;
+
+        // Only produce results that match the requested name.
+        if (!valueDecl->getName().matchesRef(name))
+          return;
+
+        result.push_back(valueDecl);
+      });
+    }
+  };
+}
+
 TinyPtrVector<ValueDecl *> CXXNamespaceMemberLookup::evaluate(
     Evaluator &evaluator, CXXNamespaceMemberLookupDescriptor desc) const {
   EnumDecl *namespaceDecl = desc.namespaceDecl;
@@ -5093,6 +5129,8 @@ TinyPtrVector<ValueDecl *> CXXNamespaceMemberLookup::evaluate(
   auto &ctx = namespaceDecl->getASTContext();
 
   TinyPtrVector<ValueDecl *> result;
+  CollectLookupResults collector(name, result);
+
   llvm::SmallPtrSet<clang::NamedDecl *, 8> importedDecls;
   for (auto redecl : clangNamespaceDecl->redecls()) {
     auto allResults = evaluateOrDefault(
@@ -5108,7 +5146,7 @@ TinyPtrVector<ValueDecl *> CXXNamespaceMemberLookup::evaluate(
         continue;
       if (auto import =
               ctx.getClangModuleLoader()->importDeclDirectly(clangMember))
-        result.push_back(cast<ValueDecl>(import));
+        collector.add(cast<ValueDecl>(import));
     }
   }
 
@@ -6206,8 +6244,11 @@ TinyPtrVector<ValueDecl *> ClangRecordMemberLookup::evaluate(
       ClangDirectLookupRequest({recordDecl, recordDecl->getClangDecl(), name}),
       {});
 
-  // Find the results that are actually a member of "recordDecl".
+  // The set of declarations we found.
   TinyPtrVector<ValueDecl *> result;
+  CollectLookupResults collector(name, result);
+
+  // Find the results that are actually a member of "recordDecl".
   ClangModuleLoader *clangModuleLoader = ctx.getClangModuleLoader();
   for (auto foundEntry : directResults) {
     auto found = foundEntry.get<clang::NamedDecl *>();
@@ -6242,7 +6283,8 @@ TinyPtrVector<ValueDecl *> ClangRecordMemberLookup::evaluate(
       if (!imported)
         continue;
     }
-    result.push_back(cast<ValueDecl>(imported));
+
+    collector.add(cast<ValueDecl>(imported));
   }
 
   if (inheritance) {
@@ -6261,7 +6303,7 @@ TinyPtrVector<ValueDecl *> ClangRecordMemberLookup::evaluate(
       if (!imported)
         continue;
 
-      result.push_back(cast<ValueDecl>(imported));
+      collector.add(imported);
     }
   }
 
@@ -6310,7 +6352,7 @@ TinyPtrVector<ValueDecl *> ClangRecordMemberLookup::evaluate(
           if (foundNameArities.count(getArity(foundInBase)))
             continue;
 
-          result.push_back(foundInBase);
+          collector.add(foundInBase);
         }
       }
     }

lib/Sema/ImportResolution.cpp

@@ -329,6 +329,11 @@ void swift::performImportResolutionForClangMacroBuffer(
   ImportResolver resolver(SF);
   resolver.addImplicitImport(clangModule);
 
+  // FIXME: This is a hack that we shouldn't need, but be sure that we can
+  // see the Swift standard library.
+  if (auto stdlib = SF.getASTContext().getStdlibModule())
+    resolver.addImplicitImport(stdlib);
+
   SF.setImports(resolver.getFinishedImports());
   SF.setImportedUnderlyingModule(resolver.getUnderlyingClangModule());
 

test/Interop/Cxx/swiftify-import/counted-by-in-namespace.swift

@@ -0,0 +1,28 @@
+// REQUIRES: swift_feature_SafeInteropWrappers
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+// RUN: %target-swift-ide-test -plugin-path %swift-plugin-dir -I %t/Inputs -cxx-interoperability-mode=upcoming-swift -enable-experimental-feature SafeInteropWrappers -print-module -module-to-print=Namespace -source-filename=x | %FileCheck %s
+// RUN: %target-swift-frontend -plugin-path %swift-plugin-dir -I %t/Inputs -cxx-interoperability-mode=default -enable-experimental-feature SafeInteropWrappers %t/namespace.swift -dump-macro-expansions -typecheck -verify
+
+// CHECK: enum foo {
+// CHECK:  static func bar(_ p: UnsafeMutableBufferPointer<Float>)
+
+//--- Inputs/module.modulemap
+module Namespace {
+    header "namespace.h"
+    requires cplusplus
+}
+
+//--- Inputs/namespace.h
+
+namespace foo {
+   __attribute__((swift_attr("@_SwiftifyImport(.countedBy(pointer: .param(1), count: \"len\"))"))) void bar(float *p, int len);
+}
+
+//--- namespace.swift
+import Namespace
+  
+func test(s: UnsafeMutableBufferPointer<Float>) {
+  foo.bar(s)
+}    

test/Interop/Cxx/swiftify-import/counted-by-method.swift

@@ -0,0 +1,30 @@
+// REQUIRES: swift_feature_SafeInteropWrappers
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+// RUN: %target-swift-ide-test -plugin-path %swift-plugin-dir -I %t/Inputs -cxx-interoperability-mode=upcoming-swift -enable-experimental-feature SafeInteropWrappers -print-module -module-to-print=Method -source-filename=x | %FileCheck %s
+// RUN: %target-swift-frontend -plugin-path %swift-plugin-dir -I %t/Inputs -cxx-interoperability-mode=default -enable-experimental-feature SafeInteropWrappers %t/method.swift -dump-macro-expansions -typecheck -verify
+
+// CHECK: @_alwaysEmitIntoClient 
+// CHECK-SAME: public mutating func bar(_ p: UnsafeMutableBufferPointer<Float>)
+
+//--- Inputs/module.modulemap
+module Method {
+    header "method.h"
+    requires cplusplus
+}
+
+//--- Inputs/method.h
+
+class Foo {
+public:
+   __attribute__((swift_attr("@_SwiftifyImport(.countedBy(pointer: .param(1), count: \"len\"))"))) void bar(float *p, int len);
+};
+
+//--- method.swift
+import Method
+  
+func test(s: UnsafeMutableBufferPointer<Float>) {
+  var foo = Foo()
+  foo.bar(s)
+}    

test/Interop/ObjC/swiftify-import/counted-by-in-class.swift

@@ -0,0 +1,29 @@
+// REQUIRES: swift_feature_SafeInteropWrappers
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+// RUN: %target-swift-ide-test -plugin-path %swift-plugin-dir -I %t/Inputs -enable-experimental-feature SafeInteropWrappers -print-module -module-to-print=Method -source-filename=x | %FileCheck %s
+// RUN: %target-swift-frontend -plugin-path %swift-plugin-dir -I %t/Inputs -enable-experimental-feature SafeInteropWrappers %t/method.swift -dump-macro-expansions -typecheck -verify
+
+// REQUIRES: objc_interop
+
+// CHECK: class Foo {
+// CHECK:  func bar(_ p: UnsafeMutableBufferPointer<Float>)
+
+//--- Inputs/module.modulemap
+module Method {
+    header "method.h"
+}
+
+//--- Inputs/method.h
+
+@interface Foo
+-(void)bar:(float *)p count:(int)len __attribute__((swift_attr("@_SwiftifyImport(.countedBy(pointer: .param(1), count: \"len\"))")));
+@end
+
+//--- method.swift
+import Method
+  
+func test(foo: Foo, s: UnsafeMutableBufferPointer<Float>) {
+  foo.bar(s)
+}