[Distributed] improve ad-hoc requirement typechecking

Author: ktoso

lib/AST/CMakeLists.txt

@@ -43,6 +43,7 @@ add_swift_host_library(swiftAST STATIC
   DiagnosticConsumer.cpp
   DiagnosticEngine.cpp
   DiagnosticList.cpp
+  DistributedDecl.cpp
   DocComment.cpp
   Effects.cpp
   Evaluator.cpp

lib/AST/Decl.cpp

@@ -7545,118 +7545,6 @@ bool AbstractFunctionDecl::isSendable() const {
   return getAttrs().hasAttribute<SendableAttr>();
 }
 
-bool AbstractFunctionDecl::isDistributedActorSystemRemoteCall(bool isVoidReturn) const {
-  auto &C = this->getASTContext();
-
-  auto callId = isVoidReturn ? C.Id_remoteCallVoid : C.Id_remoteCall;
-
-  // Check the name
-  if (getBaseName() != callId)
-    return false;
-
-  auto params = getParameters();
-  unsigned int expectedParamNum = isVoidReturn ? 4 : 5;
-
-  // Check the expected argument count:
-  if (!params || params->size() != expectedParamNum)
-    return false;
-
-  // Check API names of the arguments
-  auto actorParam = params->get(0);
-  auto targetParam = params->get(1);
-  auto invocationParam = params->get(2);
-  auto thrownTypeParam = params->get(3);
-  if (actorParam->getArgumentName() != C.Id_on ||
-      targetParam->getArgumentName() != C.Id_target ||
-      invocationParam->getArgumentName() != C.Id_invocation ||
-      thrownTypeParam->getArgumentName() != C.Id_throwing)
-    return false;
-
-  if (!isVoidReturn) {
-    auto returnedTypeParam = params->get(4);
-    if (returnedTypeParam->getArgumentName() != C.Id_returning)
-      return false;
-  }
-
-  if (!isGeneric())
-    return false;
-
-  auto genericParams = getGenericParams();
-  unsigned int expectedGenericParamNum = isVoidReturn ? 2 : 3;
-
-  // We expect: Act, Err, Res?
-  if (genericParams->size() != expectedGenericParamNum) {
-    return false;
-  }
-
-  // FIXME(distributed): check the exact generic requirements
-
-  // === check the return type
-  if (isVoidReturn) {
-    if (auto func = dyn_cast<FuncDecl>(this))
-      if (!func->getResultInterfaceType()->isVoid())
-        return false;
-  }
-
-  // FIXME(distributed): check the right types of the args and generics...
-  // FIXME(distributed): check access level actually is ok, i.e. not private etc
-
-  return true;
-}
-
-bool AbstractFunctionDecl::isDistributed() const {
-  return getAttrs().hasAttribute<DistributedActorAttr>();
-}
-
-ConstructorDecl*
-NominalTypeDecl::getDistributedRemoteCallTargetInitFunction() const {
-  auto &C = this->getASTContext();
-
-  // FIXME(distributed): implement more properly... do with caching etc
-  auto mutableThis = const_cast<NominalTypeDecl *>(this);
-  for (auto value : mutableThis->getMembers()) {
-    auto ctor = dyn_cast<ConstructorDecl>(value);
-    if (!ctor)
-      continue;
-
-    auto params = ctor->getParameters();
-    if (params->size() != 1)
-      return nullptr;
-
-    if (params->get(0)->getArgumentName() == C.getIdentifier("_mangledName"))
-      return ctor;
-
-    return nullptr;
-  }
-
-  // TODO(distributed): make a Request for it?
-  return nullptr;
-}
-
-VarDecl*
-NominalTypeDecl::getDistributedActorSystemProperty() const {
-  if (!this->isDistributedActor())
-    return nullptr;
-
-  auto mutableThis = const_cast<NominalTypeDecl *>(this);
-  return evaluateOrDefault(
-      getASTContext().evaluator,
-      GetDistributedActorSystemPropertyRequest{mutableThis},
-      nullptr);
-}
-
-VarDecl*
-NominalTypeDecl::getDistributedActorIDProperty() const {
-  if (!this->isDistributedActor())
-    return nullptr;
-
-  auto mutableThis = const_cast<NominalTypeDecl *>(this);
-  return evaluateOrDefault(
-      getASTContext().evaluator,
-      GetDistributedActorIDPropertyRequest{mutableThis},
-      nullptr);
-}
-
 BraceStmt *AbstractFunctionDecl::getBody(bool canSynthesize) const {
   if ((getBodyKind() == BodyKind::Synthesize ||
        getBodyKind() == BodyKind::Unparsed) &&