Set the param kind in ASTGen

Author: Azoy

include/swift/AST/ASTBridging.h

@@ -1887,6 +1887,15 @@ enum ENUM_EXTENSIBILITY_ATTR(open) BridgedMacroDefinitionKind : size_t {
   BridgedBuiltinIsolationMacro,
 };
 
+enum ENUM_EXTENSIBILITY_ATTR(closed) BridgedGenericTypeParamKind : size_t {
+  /// A regular generic type parameter: 'T'
+  BridgedGenericTypeParamKindType = 0,
+  /// A generic parameter pack: 'each T'
+  BridgedGenericTypeParamKindPack,
+  /// A generic value parameter: 'let T'
+  BridgedGenericTypeParamKindValue,
+};
+
 SWIFT_NAME("BridgedGenericParamList.createParsed(_:leftAngleLoc:parameters:"
            "genericWhereClause:rightAngleLoc:)")
 BridgedGenericParamList BridgedGenericParamList_createParsed(
@@ -1897,12 +1906,12 @@ BridgedGenericParamList BridgedGenericParamList_createParsed(
 
 SWIFT_NAME(
     "BridgedGenericTypeParamDecl.createParsed(_:declContext:specifierLoc:"
-    "name:nameLoc:inheritedType:index:)")
+    "name:nameLoc:inheritedType:index:paramKind:)")
 BridgedGenericTypeParamDecl BridgedGenericTypeParamDecl_createParsed(
     BridgedASTContext cContext, BridgedDeclContext cDeclContext,
     BridgedSourceLoc cSpecifierLoc, BridgedIdentifier cName,
     BridgedSourceLoc cNameLoc, BridgedNullableTypeRepr opaqueInheritedType,
-    size_t index);
+    size_t index, BridgedGenericTypeParamKind paramKind);
 
 SWIFT_NAME(
     "BridgedTrailingWhereClause.createParsed(_:whereKeywordLoc:requirements:)")

lib/AST/ASTBridging.cpp

@@ -2610,11 +2610,26 @@ BridgedGenericTypeParamDecl BridgedGenericTypeParamDecl_createParsed(
     BridgedASTContext cContext, BridgedDeclContext cDeclContext,
     BridgedSourceLoc cSpecifierLoc, BridgedIdentifier cName,
     BridgedSourceLoc cNameLoc, BridgedNullableTypeRepr bridgedInheritedType,
-    size_t index) {
+    size_t index, BridgedGenericTypeParamKind cParamKind) {
   auto specifierLoc = cSpecifierLoc.unbridged();
+
+  GenericTypeParamKind paramKind;
+
+  switch (cParamKind) {
+  case BridgedGenericTypeParamKindType:
+    paramKind = GenericTypeParamKind::Type;
+    break;
+  case BridgedGenericTypeParamKindPack:
+    paramKind = GenericTypeParamKind::Pack;
+    break;
+  case BridgedGenericTypeParamKindValue:
+    paramKind = GenericTypeParamKind::Value;
+    break;
+  }
+
   auto *decl = GenericTypeParamDecl::createParsed(
       cDeclContext.unbridged(), cName.unbridged(), cNameLoc.unbridged(),
-      specifierLoc, index, GenericTypeParamKind::Type); // FIXME
+      specifierLoc, index, paramKind);
 
   if (auto *inheritedType = bridgedInheritedType.unbridged()) {
     auto entry = InheritedEntry(inheritedType);

lib/ASTGen/Sources/ASTGen/Generics.swift

@@ -38,16 +38,23 @@ extension ASTGenVisitor {
       preconditionFailure("Node not part of the parent?")
     }
 
+    var paramKind: BridgedGenericTypeParamKind = .type
+
+    if node.specifier?.tokenKind == .keyword(.each) {
+      paramKind = .pack
+    } else if node.specifier?.tokenKind == .keyword(.let) {
+      paramKind = .value
+    }
+
     return .createParsed(
       self.ctx,
       declContext: self.declContext,
-
-      // FIXME ALEX
-      specifierLoc: self.generateSourceLoc(node.eachKeyword),
+      specifierLoc: self.generateSourceLoc(node.specifier),
       name: name,
       nameLoc: nameLoc,
       inheritedType: self.generate(type: node.inheritedType),
-      index: genericParameterIndex
+      index: genericParameterIndex,
+      paramKind: paramKind
     )
   }
 

test/ASTGen/decls.swift

@@ -284,3 +284,9 @@ struct TestStruct {
 // FIXME: Compute 'static' location
 //  static func instance(arg: Int) -> TestStruct { return TestStruct() }
 }
+
+struct ValueStruct<let N: Int> {}
+
+func genericTest1<T>(_: T) {}
+func genericTest2<each T>(_: repeat each T) {}
+func genericTest4<let T: Int>(_: ValueStruct<T>) {}