Skip to content

Commit c0b5925

Browse files
committed
[CMake] Removed an overwrite of the SOURCEKIT_DEPLOYMENT_TARGET setting.
This setting is set early in SourceKit's CMake logic to match Swift's CMake settings. However, it was then reset back to the empty string. The CMake logic would then see that it was unset and use the host OS as the deployment target. Thankfully, the compiled binaries have been correct without this change, but sourcekitd.framework's Info.plist when building for iOS was incorrect. By removing the reset, the correct value propagates to the right places. This is for <rdar://problem/85511244> and addresses <rdar://problem/68656762>.
1 parent 546a646 commit c0b5925

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

tools/SourceKit/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ include(AddSwiftSourceKit)
5252

5353
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
5454
# Choose a deployment target if none was set.
55-
set(SOURCEKIT_DEPLOYMENT_TARGET "" CACHE STRING
56-
"Deployment target for SourceKit.")
5755
if (NOT SOURCEKIT_DEPLOYMENT_TARGET)
5856
execute_process(COMMAND sw_vers -productVersion
5957
OUTPUT_VARIABLE SOURCEKIT_DEPLOYMENT_TARGET

0 commit comments

Comments
 (0)