[AST] Namelookup should only look at parsed generic parameters

angela-laar · angela-laar · commit c3d4b3d985fd · 2022-09-20T15:25:09.000-07:00
We want to make sure not to cause a circular reference
by fetching the full generic parameter list when we are
creating opaque paramters and result types.
diff --git a/lib/AST/ASTScopeLookup.cpp b/lib/AST/ASTScopeLookup.cpp
@@ -166,10 +166,10 @@ NullablePtr<const GenericParamList> ASTScopeImpl::genericParams() const {
 }
 NullablePtr<const GenericParamList>
 AbstractFunctionDeclScope::genericParams() const {
-  return decl->getGenericParams();
+  return decl->getParsedGenericParams();
 }
 NullablePtr<const GenericParamList> SubscriptDeclScope::genericParams() const {
-  return decl->getGenericParams();
+  return decl->getParsedGenericParams();
 }
 NullablePtr<const GenericParamList> GenericTypeScope::genericParams() const {
   // For Decls:

Original file line number	Diff line number	Diff line change
`@@ -166,10 +166,10 @@ NullablePtr<const GenericParamList> ASTScopeImpl::genericParams() const {`
`166`	`166`	`}`
`167`	`167`	`NullablePtr<const GenericParamList>`
`168`	`168`	`AbstractFunctionDeclScope::genericParams() const {`
`169`		`- return decl->getGenericParams();`
	`169`	`+ return decl->getParsedGenericParams();`
`170`	`170`	`}`
`171`	`171`	`NullablePtr<const GenericParamList> SubscriptDeclScope::genericParams() const {`
`172`		`- return decl->getGenericParams();`
	`172`	`+ return decl->getParsedGenericParams();`
`173`	`173`	`}`
`174`	`174`	`NullablePtr<const GenericParamList> GenericTypeScope::genericParams() const {`
`175`	`175`	`// For Decls:`