Skip to content

Commit c49f0c4

Browse files
committed
[TypeChecker] NFC: Clarify flaky diagnostic XFAIL
Instead of XFAILing whole `test/Constraints/operator.swift` let's adjust diagnostic responsible for flakiness. (cherry picked from commit 1715021)
1 parent 91d3180 commit c49f0c4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

test/Constraints/operator.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,11 +216,13 @@ func rdar46459603() {
216216
let e = E.foo(value: "String")
217217
var arr = ["key": e]
218218

219+
// FIXME(rdar://problem/64844584) - on iOS simulator this diagnostic is flaky,
220+
// either `referencing operator function '==' on 'Equatable'` or `operator function '==' requires`
219221
_ = arr.values == [e]
220-
// expected-error@-1 {{referencing operator function '==' on 'Equatable' requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
222+
// expected-error@-1 {{requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
221223
// expected-error@-2 {{cannot convert value of type '[E]' to expected argument type 'Dictionary<String, E>.Values'}}
222224
_ = [arr.values] == [[e]]
223-
// expected-error@-1 {{operator function '==' requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
225+
// expected-error@-1 {{requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
224226
// expected-error@-2 {{cannot convert value of type '[E]' to expected element type 'Dictionary<String, E>.Values'}}
225227
}
226228

0 commit comments

Comments
 (0)