[Stdlib] Change _swift_stdlib_random SPI to swift_stdlib_random API.

Author: mikeash

stdlib/public/SwiftShims/Random.h

@@ -28,8 +28,8 @@
 namespace swift { extern "C" {
 #endif
 
-SWIFT_RUNTIME_STDLIB_SPI
-void _swift_stdlib_random(void *buf, __swift_size_t nbytes);
+SWIFT_RUNTIME_STDLIB_API
+void swift_stdlib_random(void *buf, __swift_size_t nbytes);
 
 #ifdef __cplusplus
 }} // extern "C", namespace swift

stdlib/public/core/Random.swift

@@ -164,14 +164,14 @@ public struct SystemRandomNumberGenerator : RandomNumberGenerator {
   @inlinable
   public mutating func next() -> UInt64 {
     var random: UInt64 = 0
-    _swift_stdlib_random(&random, MemoryLayout<UInt64>.size)
+    swift_stdlib_random(&random, MemoryLayout<UInt64>.size)
     return random
   }
 
   @inlinable
   public mutating func _fill(bytes buffer: UnsafeMutableRawBufferPointer) {
     if !buffer.isEmpty {
-      _swift_stdlib_random(buffer.baseAddress!, buffer.count)
+      swift_stdlib_random(buffer.baseAddress!, buffer.count)
     }
   }
 }

stdlib/public/stubs/GlobalObjects.cpp

@@ -115,8 +115,8 @@ static swift::_SwiftHashingParameters initializeHashingParameters() {
     return { 0, 0, true };
   }
   __swift_uint64_t seed0 = 0, seed1 = 0;
-  swift::_swift_stdlib_random(&seed0, sizeof(seed0));
-  swift::_swift_stdlib_random(&seed1, sizeof(seed1));
+  swift::swift_stdlib_random(&seed0, sizeof(seed0));
+  swift::swift_stdlib_random(&seed1, sizeof(seed1));
   return { seed0, seed1, false };
 }
 

stdlib/public/stubs/Random.cpp

@@ -10,7 +10,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-// _swift_stdlib_random
+// swift_stdlib_random
 //
 // Should the implementation of this function add a new platform/change for a
 // platform, make sure to also update the documentation regarding platform
@@ -40,16 +40,16 @@
 
 #if defined(__APPLE__)
 
-SWIFT_RUNTIME_STDLIB_SPI
-void swift::_swift_stdlib_random(void *buf, __swift_size_t nbytes) {
+SWIFT_RUNTIME_STDLIB_API
+void swift::swift_stdlib_random(void *buf, __swift_size_t nbytes) {
   arc4random_buf(buf, nbytes);
 }
 
 #elif defined(_WIN32) && !defined(__CYGWIN__)
-#warning TODO: Test _swift_stdlib_random on Windows
+#warning TODO: Test swift_stdlib_random on Windows
 
-SWIFT_RUNTIME_STDLIB_SPI
-void swift::_swift_stdlib_random(void *buf, __swift_size_t nbytes) {
+SWIFT_RUNTIME_STDLIB_API
+void swift::swift_stdlib_random(void *buf, __swift_size_t nbytes) {
   NTSTATUS status = BCryptGenRandom(nullptr,
                                     static_cast<PUCHAR>(buf),
                                     static_cast<ULONG>(nbytes),
@@ -68,8 +68,8 @@ void swift::_swift_stdlib_random(void *buf, __swift_size_t nbytes) {
   result;                                                                      \
 })
 
-SWIFT_RUNTIME_STDLIB_SPI
-void swift::_swift_stdlib_random(void *buf, __swift_size_t nbytes) {
+SWIFT_RUNTIME_STDLIB_API
+void swift::swift_stdlib_random(void *buf, __swift_size_t nbytes) {
   while (nbytes > 0) {
     __swift_ssize_t actual_nbytes = -1;