ABIChecker: contains only opaque accessors for ABI/API checking

rdar://53776566

Author: nkcsgexi

include/swift/AST/Decl.h

@@ -4686,6 +4686,10 @@ class AbstractStorageDecl : public ValueDecl {
   /// To ensure an accessor is always returned, use getSynthesizedAccessor().
   AccessorDecl *getOpaqueAccessor(AccessorKind kind) const;
 
+  /// Collect all opaque accessors.
+  ArrayRef<AccessorDecl*>
+    getOpaqueAccessors(llvm::SmallVectorImpl<AccessorDecl*> &scratch) const;
+
   /// Return an accessor that was written in source. Returns null if the
   /// accessor was not explicitly defined by the user.
   AccessorDecl *getParsedAccessor(AccessorKind kind) const;

lib/AST/Decl.cpp

@@ -2225,6 +2225,12 @@ AccessorDecl *AbstractStorageDecl::getOpaqueAccessor(AccessorKind kind) const {
   return getSynthesizedAccessor(kind);
 }
 
+ArrayRef<AccessorDecl*> AbstractStorageDecl::getOpaqueAccessors(
+    llvm::SmallVectorImpl<AccessorDecl*> &scratch) const {
+  visitOpaqueAccessors([&](AccessorDecl *D) { scratch.push_back(D); });
+  return scratch;
+}
+
 bool AbstractStorageDecl::hasParsedAccessors() const {
   for (auto *accessor : getAllAccessors())
     if (!accessor->isImplicit())

test/api-digester/Outputs/Cake-abi.txt

@@ -12,7 +12,6 @@ cake: Accessor RemoveSetters.Value.Modify() has been removed
 cake: Accessor RemoveSetters.Value.Set() has been removed
 cake: Accessor RemoveSetters.subscript(_:).Modify() has been removed
 cake: Accessor RemoveSetters.subscript(_:).Set() has been removed
-cake: Accessor fixedLayoutStruct.height.Read() has been removed
 cake: AssociatedType RequiementChanges.removedType has been removed
 cake: Class C3 has been removed
 cake: Constructor Somestruct2.init(_:) has been removed

tools/swift-api-digester/ModuleAnalyzerNodes.cpp

@@ -1694,7 +1694,8 @@ SwiftDeclCollector::constructVarNode(ValueDecl *VD) {
   Info.IsImplicitlyUnwrappedOptional = VD->isImplicitlyUnwrappedOptional();
   Var->addChild(constructTypeNode(VD->getInterfaceType(), Info));
   if (auto VAD = dyn_cast<AbstractStorageDecl>(VD)) {
-    for(auto *AC: VAD->getAllAccessors()) {
+    llvm::SmallVector<AccessorDecl*, 4> scratch;
+    for(auto *AC: VAD->getOpaqueAccessors(scratch)) {
       if (!Ctx.shouldIgnore(AC, VAD)) {
         Var->addAccessor(constructFunctionNode(AC, SDKNodeKind::DeclAccessor));
       }
@@ -1728,7 +1729,8 @@ SwiftDeclCollector::constructSubscriptDeclNode(SubscriptDecl *SD) {
   for (auto *Node: createParameterNodes(SD->getIndices())) {
     Subs->addChild(Node);
   }
-  for(auto *AC: SD->getAllAccessors()) {
+  llvm::SmallVector<AccessorDecl*, 4> scratch;
+  for(auto *AC: SD->getOpaqueAccessors(scratch)) {
     if (!Ctx.shouldIgnore(AC, SD)) {
       Subs->addAccessor(constructFunctionNode(AC, SDKNodeKind::DeclAccessor));
     }