Remove ArchetypeType::getKnownNestedTypes().

This API is only used for dumping and verification, and is not
intended to remain a meaningful query.

Author: DougGregor

include/swift/AST/Types.h

@@ -5466,14 +5466,6 @@ class ArchetypeType : public SubstitutableType,
   /// Check if the archetype contains a nested type with the given name.
   bool hasNestedType(Identifier Name) const;
 
-  /// Retrieve the known nested types of this archetype.
-  ///
-  /// Useful only for debugging dumps; all other queries should attempt to
-  /// find a particular nested type by name, directly, or look at the
-  /// protocols to which this archetype conforms.
-  ArrayRef<std::pair<Identifier, Type>>
-  getKnownNestedTypes() const;
-
   /// Register a nested type with the given name.
   void registerNestedType(Identifier name, Type nested);
 

lib/AST/ASTDumper.cpp

@@ -3733,45 +3733,23 @@ namespace {
         printRec("superclass", superclass);
     }
 
-    void printArchetypeNestedTypes(ArchetypeType *T) {
-      Indent += 2;
-      for (auto nestedType : T->getKnownNestedTypes()) {
-        OS << "\n";
-        OS.indent(Indent) << "(";
-        PrintWithColorRAII(OS, TypeFieldColor) << "nested_type";
-        OS << "=";
-        OS << nestedType.first.str() << " ";
-        if (!nestedType.second) {
-          PrintWithColorRAII(OS, TypeColor) << "<<unresolved>>";
-        } else {
-          PrintWithColorRAII(OS, TypeColor);
-          OS << "=" << nestedType.second.getString();
-        }
-        OS << ")";
-      }
-      Indent -= 2;
-    }
-
     void visitPrimaryArchetypeType(PrimaryArchetypeType *T, StringRef label) {
       printArchetypeCommon(T, "primary_archetype_type", label);
       printField("name", T->getFullName());
       OS << "\n";
-      printArchetypeNestedTypes(T);
       PrintWithColorRAII(OS, ParenthesisColor) << ')';
     }
     void visitNestedArchetypeType(NestedArchetypeType *T, StringRef label) {
       printArchetypeCommon(T, "nested_archetype_type", label);
       printField("name", T->getFullName());
       printField("parent", T->getParent());
       printField("assoc_type", T->getAssocType()->printRef());
-      printArchetypeNestedTypes(T);
       PrintWithColorRAII(OS, ParenthesisColor) << ')';
     }
     void visitOpenedArchetypeType(OpenedArchetypeType *T, StringRef label) {
       printArchetypeCommon(T, "opened_archetype_type", label);
       printRec("opened_existential", T->getOpenedExistentialType());
       printField("opened_existential_id", T->getOpenedExistentialID());
-      printArchetypeNestedTypes(T);
       PrintWithColorRAII(OS, ParenthesisColor) << ')';
     }
     void visitOpaqueTypeArchetypeType(OpaqueTypeArchetypeType *T,
@@ -3786,14 +3764,12 @@ namespace {
                                SubstitutionMap::DumpStyle::Full,
                                Indent + 2, Dumped);
       }
-      printArchetypeNestedTypes(T);
       PrintWithColorRAII(OS, ParenthesisColor) << ')';
     }
     void visitSequenceArchetypeType(SequenceArchetypeType *T, StringRef label) {
       printArchetypeCommon(T, "sequence_archetype_type", label);
       printField("name", T->getFullName());
       OS << "\n";
-      printArchetypeNestedTypes(T);
       PrintWithColorRAII(OS, ParenthesisColor) << ')';
     }
 

lib/AST/ASTVerifier.cpp

@@ -658,24 +658,6 @@ class Verifier : public ASTWalker {
 
             return true;
           }
-
-          // Make sure that none of the nested types are dependent.
-          for (const auto &nested : archetype->getKnownNestedTypes()) {
-            if (!nested.second)
-              continue;
-            
-            if (auto nestedType = nested.second) {
-              if (nestedType->hasTypeParameter()) {
-                Out << "Nested type " << nested.first.str()
-                    << " of archetype " << archetype->getString()
-                    << " is dependent type " << nestedType->getString()
-                    << "\n";
-                return true;
-              }
-            }
-
-            verifyChecked(nested.second, visitedArchetypes);
-          }
         }
 
         return false;

lib/AST/Type.cpp

@@ -3767,12 +3767,6 @@ bool ArchetypeType::hasNestedType(Identifier Name) const {
   return Pos != NestedTypes.end() && Pos->first == Name;
 }
 
-ArrayRef<std::pair<Identifier, Type>>
-ArchetypeType::getKnownNestedTypes() const {
-  populateNestedTypes();
-  return NestedTypes;
-}
-
 void ArchetypeType::registerNestedType(Identifier name, Type nested) {
   populateNestedTypes();