In OSSA rauw utilities use auto generated location for creating copy_value/destroy_value etc

Branch instructions and frontiers can have
LocationKind::ReturnKind/ImplicitReturnKind which are not correct
locations to use for copy_value/destroy_value etc

Author: meg-gupta

lib/SILOptimizer/Utils/OwnershipOptUtils.cpp

@@ -221,8 +221,12 @@ OwnershipLifetimeExtender::copyBorrowAndExtendForRAUW(SILValue newValue,
   while (!frontier.empty()) {
     auto *insertPt = frontier.pop_back_val();
     SILBuilderWithScope frontierBuilder(insertPt);
-    auto *ebi = frontierBuilder.createEndBorrow(insertPt->getLoc(), borrow);
-    auto *dvi = frontierBuilder.createDestroyValue(insertPt->getLoc(), copy);
+    // Use an auto-generated location here, because insertPt may have an
+    // incompatible LocationKind
+    auto loc = RegularLocation::getAutoGeneratedLocation(
+        insertPt->getLoc().getSourceLoc());
+    auto *ebi = frontierBuilder.createEndBorrow(loc, borrow);
+    auto *dvi = frontierBuilder.createDestroyValue(loc, copy);
     if (ctx.newInstNotify) {
       ctx.newInstNotify(ebi);
       ctx.newInstNotify(dvi);
@@ -460,10 +464,13 @@ void OwnershipRAUWUtility::eliminateReborrowsOfRecursiveBorrows(
     SILValue value = borrowingOperand->get();
     auto *bi = cast<BranchInst>(borrowingOperand->getUser());
     SILBuilderWithScope reborrowBuilder(bi);
-    auto *innerCopy = reborrowBuilder.createCopyValue(bi->getLoc(), value);
-    auto *innerBorrow =
-        reborrowBuilder.createBeginBorrow(bi->getLoc(), innerCopy);
-    auto *outerEndBorrow = reborrowBuilder.createEndBorrow(bi->getLoc(), value);
+    // Use an auto-generated location here, because the branch may have an
+    // incompatible LocationKind
+    auto loc =
+        RegularLocation::getAutoGeneratedLocation(bi->getLoc().getSourceLoc());
+    auto *innerCopy = reborrowBuilder.createCopyValue(loc, value);
+    auto *innerBorrow = reborrowBuilder.createBeginBorrow(loc, innerCopy);
+    auto *outerEndBorrow = reborrowBuilder.createEndBorrow(loc, value);
     if (ctx.newInstNotify) {
       ctx.newInstNotify(innerCopy);
       ctx.newInstNotify(innerBorrow);
@@ -526,12 +533,14 @@ void OwnershipRAUWUtility::rewriteReborrows(
   for (auto reborrow : foundReborrows) {
     auto *bi = cast<BranchInst>(reborrow.op->getUser());
     SILBuilderWithScope reborrowBuilder(bi);
-    auto *innerCopy =
-        reborrowBuilder.createCopyValue(bi->getLoc(), newBorrowedValue);
-    auto *innerBorrow =
-        reborrowBuilder.createBeginBorrow(bi->getLoc(), innerCopy);
+    // Use an auto-generated location here, because the branch may have an
+    // incompatible LocationKind
+    auto loc =
+        RegularLocation::getAutoGeneratedLocation(bi->getLoc().getSourceLoc());
+    auto *innerCopy = reborrowBuilder.createCopyValue(loc, newBorrowedValue);
+    auto *innerBorrow = reborrowBuilder.createBeginBorrow(loc, innerCopy);
     auto *outerEndBorrow =
-        reborrowBuilder.createEndBorrow(bi->getLoc(), reborrow.op->get());
+        reborrowBuilder.createEndBorrow(loc, reborrow.op->get());
     if (ctx.newInstNotify) {
       ctx.newInstNotify(innerCopy);
       ctx.newInstNotify(innerBorrow);