Merge pull request swiftlang#30224 from atrick/disable-invariant-let

Disable !invariant metadata for 'let' variables.

Author: atrick

lib/IRGen/IRGenSIL.cpp

@@ -3569,16 +3569,16 @@ void IRGenSILFunction::visitRefTailAddrInst(RefTailAddrInst *i) {
 
 static bool isInvariantAddress(SILValue v) {
   SILValue accessedAddress = getAccessedAddress(v);
-  if (accessedAddress->getType().isAddress() && isLetAddress(accessedAddress)) {
-    return true;
-  }
   if (auto *ptrRoot = dyn_cast<PointerToAddressInst>(accessedAddress)) {
     return ptrRoot->isInvariant();
   }
   // TODO: We could be more aggressive about considering addresses based on
   // `let` variables as invariant when the type of the address is known not to
   // have any sharably-mutable interior storage (in other words, no weak refs,
-  // atomics, etc.)
+  // atomics, etc.). However, this currently miscompiles some programs.
+  // if (accessedAddress->getType().isAddress() && isLetAddress(accessedAddress)) {
+  //  return true;
+  // }
   return false;
 }
 

test/IRGen/invariant_load.sil

@@ -1,5 +1,9 @@
 // RUN: %target-swift-frontend -emit-ir %s | %FileCheck %s
 
+// REQUIRES: rdar60068448
+// FIXME Reenable the !invariant.load metadata after debugging miscompiles...
+// <rdar://60068448> Teach IRGen to emit !invariant metadata for 'let' variables
+
 sil_stage lowered
 
 import Builtin