AST: Change some writeDependencySink() methods to take the result by const reference

Author: slavapestov

include/swift/AST/NameLookupRequests.h

@@ -406,7 +406,7 @@ class UnqualifiedLookupRequest
 public:
   // Incremental dependencies
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           LookupResult res) const;
+                           const LookupResult &res) const;
 };
 
 using QualifiedLookupResult = SmallVector<ValueDecl *, 4>;
@@ -434,7 +434,7 @@ class LookupInModuleRequest
 public:
   // Incremental dependencies
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           QualifiedLookupResult l) const;
+                           const QualifiedLookupResult &l) const;
 };
 
 /// Perform \c AnyObject lookup for a given member.
@@ -457,7 +457,7 @@ class AnyObjectLookupRequest
 public:
   // Incremental dependencies
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           QualifiedLookupResult l) const;
+                           const QualifiedLookupResult &l) const;
 };
 
 class ModuleQualifiedLookupRequest
@@ -482,7 +482,7 @@ class ModuleQualifiedLookupRequest
 public:
   // Incremental dependencies
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           QualifiedLookupResult lookupResult) const;
+                           const QualifiedLookupResult &lookupResult) const;
 };
 
 class QualifiedLookupRequest
@@ -555,7 +555,7 @@ class DirectLookupRequest
 public:
   // Incremental dependencies
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           TinyPtrVector<ValueDecl *> result) const;
+                           const TinyPtrVector<ValueDecl *> &result) const;
 };
 
 class OperatorLookupDescriptor final {
@@ -636,7 +636,7 @@ class DirectOperatorLookupRequest
 public:
   // Incremental dependencies.
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           TinyPtrVector<OperatorDecl *> ops) const;
+                           const TinyPtrVector<OperatorDecl *> &ops) const;
 };
 
 /// Looks up an precedencegroup in a given file or module without looking
@@ -659,7 +659,7 @@ class DirectPrecedenceGroupLookupRequest
 public:
   // Incremental dependencies.
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           TinyPtrVector<PrecedenceGroupDecl *> groups) const;
+                           const TinyPtrVector<PrecedenceGroupDecl *> &groups) const;
 };
 
 class LookupConformanceDescriptor final {

include/swift/AST/TypeCheckRequests.h

@@ -2504,7 +2504,7 @@ class LookupAllConformancesInContextRequest
 
   // Incremental dependencies
   void writeDependencySink(evaluator::DependencyCollector &tracker,
-                           ProtocolConformanceLookupResult r) const;
+                           const ProtocolConformanceLookupResult &r) const;
 };
 
 class CheckRedeclarationRequest

lib/AST/Module.cpp

@@ -1109,7 +1109,7 @@ syntax::SourceFileSyntax SourceFile::getSyntaxRoot() const {
 
 void DirectOperatorLookupRequest::writeDependencySink(
     evaluator::DependencyCollector &reqTracker,
-    TinyPtrVector<OperatorDecl *> ops) const {
+    const TinyPtrVector<OperatorDecl *> &ops) const {
   auto &desc = std::get<0>(getStorage());
   reqTracker.addTopLevelName(desc.name);
 }
@@ -1144,7 +1144,7 @@ void SourceFile::lookupOperatorDirect(
 
 void DirectPrecedenceGroupLookupRequest::writeDependencySink(
     evaluator::DependencyCollector &reqTracker,
-    TinyPtrVector<PrecedenceGroupDecl *> groups) const {
+    const TinyPtrVector<PrecedenceGroupDecl *> &groups) const {
   auto &desc = std::get<0>(getStorage());
   reqTracker.addTopLevelName(desc.name);
 }

lib/AST/NameLookupRequests.cpp

@@ -175,7 +175,8 @@ void ExtendedNominalRequest::cacheResult(NominalTypeDecl *value) const {
 }
 
 void ExtendedNominalRequest::writeDependencySink(
-    evaluator::DependencyCollector &tracker, NominalTypeDecl *value) const {
+    evaluator::DependencyCollector &tracker,
+    NominalTypeDecl *value) const {
   if (!value)
     return;
 
@@ -303,7 +304,7 @@ SourceLoc swift::extractNearestSourceLoc(const OperatorLookupDescriptor &desc) {
 
 void DirectLookupRequest::writeDependencySink(
     evaluator::DependencyCollector &tracker,
-    TinyPtrVector<ValueDecl *> result) const {
+    const TinyPtrVector<ValueDecl *> &result) const {
   auto &desc = std::get<0>(getStorage());
   tracker.addUsedMember(desc.DC, desc.Name.getBaseName());
 }
@@ -313,7 +314,8 @@ void DirectLookupRequest::writeDependencySink(
 //----------------------------------------------------------------------------//
 
 void LookupInModuleRequest::writeDependencySink(
-    evaluator::DependencyCollector &reqTracker, QualifiedLookupResult l) const {
+    evaluator::DependencyCollector &reqTracker,
+    const QualifiedLookupResult &l) const {
   auto *DC = std::get<0>(getStorage());
   auto member = std::get<1>(getStorage());
 
@@ -340,7 +342,8 @@ void swift::simple_display(llvm::raw_ostream &out,
 }
 
 void AnyObjectLookupRequest::writeDependencySink(
-    evaluator::DependencyCollector &reqTracker, QualifiedLookupResult l) const {
+    evaluator::DependencyCollector &reqTracker,
+    const QualifiedLookupResult &l) const {
   auto member = std::get<1>(getStorage());
   reqTracker.addDynamicLookupName(member.getBaseName());
 }
@@ -355,7 +358,8 @@ swift::extractNearestSourceLoc(const LookupConformanceDescriptor &desc) {
 //----------------------------------------------------------------------------//
 
 void ModuleQualifiedLookupRequest::writeDependencySink(
-    evaluator::DependencyCollector &reqTracker, QualifiedLookupResult l) const {
+    evaluator::DependencyCollector &reqTracker,
+    const QualifiedLookupResult &l) const {
   auto *module = std::get<1>(getStorage());
   auto member = std::get<2>(getStorage());
 
@@ -395,7 +399,8 @@ void LookupConformanceInModuleRequest::writeDependencySink(
 //----------------------------------------------------------------------------//
 
 void UnqualifiedLookupRequest::writeDependencySink(
-    evaluator::DependencyCollector &track, LookupResult res) const {
+    evaluator::DependencyCollector &track,
+    const LookupResult &res) const {
   auto &desc = std::get<0>(getStorage());
   track.addTopLevelName(desc.Name.getBaseName());
 }

lib/AST/TypeCheckRequests.cpp

@@ -1290,7 +1290,7 @@ void CheckRedeclarationRequest::writeDependencySink(
 
 void LookupAllConformancesInContextRequest::writeDependencySink(
     evaluator::DependencyCollector &tracker,
-    ProtocolConformanceLookupResult conformances) const {
+    const ProtocolConformanceLookupResult &conformances) const {
   for (auto conformance : conformances) {
     tracker.addPotentialMember(conformance->getProtocol());
   }