[Gardening] dyn_cast -> isa

Author: CodaFi

include/swift/SIL/AbstractionPattern.h

@@ -675,7 +675,7 @@ class AbstractionPattern {
           isa<GenericTypeParamType>(type)) {
         return true;
       }
-      if (auto archetype = dyn_cast<ArchetypeType>(type)) {
+      if (isa<ArchetypeType>(type)) {
         return true;
       }
       return false;

lib/AST/ASTScopeCreation.cpp

@@ -523,7 +523,7 @@ class ScopeCreator final {
           // get inactive nodes that nest in active clauses
           for (auto n : clause.Elements) {
             if (auto *const d = n.dyn_cast<Decl *>())
-              if (auto *const icd = dyn_cast<IfConfigDecl>(d))
+              if (isa<IfConfigDecl>(d))
                 expandIfConfigClausesInto(expansion, {d}, true);
           }
         } else if (includeInactiveIfConfigClauses) {
@@ -1776,7 +1776,7 @@ void ScopeCreator::forEachClosureIn(
       return {true, E};
     }
     std::pair<bool, Stmt *> walkToStmtPre(Stmt *S) override {
-      if (auto *bs = dyn_cast<BraceStmt>(S)) { // closures hidden in here
+      if (isa<BraceStmt>(S)) { // closures hidden in here
         return {true, S};
       }
       return {false, S};
@@ -2132,7 +2132,7 @@ class LocalizableDeclContextCollector : public ASTWalker {
     auto f = SM.getIdentifierForBuffer(bufID);
     auto lin = SM.getLineNumber(loc);
     if (f.endswith(file) && lin == line)
-      if (auto *v = dyn_cast<PatternBindingDecl>(D))
+      if (isa<PatternBindingDecl>(D))
         llvm::errs() << "*** catchForDebugging: " << lin << " ***\n";
   }
 };

lib/AST/AccessRequests.cpp

@@ -68,7 +68,7 @@ AccessLevelRequest::evaluate(Evaluator &evaluator, ValueDecl *D) const {
 
   // Special case for generic parameters; we just give them a dummy
   // access level.
-  if (auto genericParam = dyn_cast<GenericTypeParamDecl>(D)) {
+  if (isa<GenericTypeParamDecl>(D)) {
     return AccessLevel::Internal;
   }
 

lib/AST/Decl.cpp

@@ -645,7 +645,7 @@ Expr *AbstractFunctionDecl::getSingleExpressionBody() const {
   if (auto *stmt = body.dyn_cast<Stmt *>()) {
     if (auto *returnStmt = dyn_cast<ReturnStmt>(stmt)) {
       return returnStmt->getResult();
-    } else if (auto *failStmt = dyn_cast<FailStmt>(stmt)) {
+    } else if (isa<FailStmt>(stmt)) {
       // We can only get to this point if we're a type-checked ConstructorDecl
       // which was originally spelled init?(...) { nil }.  
       //
@@ -663,7 +663,7 @@ void AbstractFunctionDecl::setSingleExpressionBody(Expr *NewBody) {
     if (auto *returnStmt = dyn_cast<ReturnStmt>(stmt)) {
       returnStmt->setResult(NewBody);
       return;
-    } else if (auto *failStmt = dyn_cast<FailStmt>(stmt)) {
+    } else if (isa<FailStmt>(stmt)) {
       // We can only get to this point if we're a type-checked ConstructorDecl
       // which was originally spelled init?(...) { nil }.  
       //
@@ -780,7 +780,7 @@ bool Decl::isPrivateStdlibDecl(bool treatNonBuiltinProtocolsAsPublic) const {
       FU->getKind() != FileUnitKind::SerializedAST)
     return false;
 
-  if (auto PD = dyn_cast<ProtocolDecl>(D)) {
+  if (isa<ProtocolDecl>(D)) {
     if (treatNonBuiltinProtocolsAsPublic)
       return false;
   }
@@ -2657,7 +2657,7 @@ static Type mapSignatureFunctionType(ASTContext &ctx, Type type,
 
     // Functions and subscripts cannot overload differing only in opaque return
     // types. Replace the opaque type with `Any`.
-    if (auto opaque = type->getAs<OpaqueTypeArchetypeType>()) {
+    if (type->is<OpaqueTypeArchetypeType>()) {
       type = ProtocolCompositionType::get(ctx, {}, /*hasAnyObject*/ false);
     }
 

lib/AST/Type.cpp

@@ -3442,7 +3442,7 @@ Type DependentMemberType::substBaseType(Type substBase,
 Type DependentMemberType::substRootParam(Type newRoot,
                                          LookupConformanceFn lookupConformance){
   auto base = getBase();
-  if (auto param = base->getAs<GenericTypeParamType>()) {
+  if (base->is<GenericTypeParamType>()) {
     return substBaseType(newRoot, lookupConformance);
   }
   if (auto depMem = base->getAs<DependentMemberType>()) {
@@ -3633,7 +3633,7 @@ static Type substType(Type derivedType,
     if (isa<GenericTypeParamType>(substOrig))
       return ErrorType::get(type);
 
-    if (auto primaryArchetype = dyn_cast<PrimaryArchetypeType>(substOrig))
+    if (isa<PrimaryArchetypeType>(substOrig))
       return ErrorType::get(type);
 
     // Opened existentials cannot be substituted in this manner,

lib/Driver/Driver.cpp

@@ -2347,7 +2347,7 @@ static StringRef baseNameForImage(const JobAction *JA, const OutputInfo &OI,
   if (JA->size() == 1 && OI.ModuleNameIsFallback && BaseInput != "-")
     return llvm::sys::path::stem(BaseInput);
 
-  if (auto link = dyn_cast<StaticLinkJobAction>(JA)) {
+  if (isa<StaticLinkJobAction>(JA)) {
     Buffer = "lib";
     Buffer.append(BaseName);
     Buffer.append(Triple.isOSWindows() ? ".lib" : ".a");

lib/IDE/CodeCompletion.cpp

@@ -5239,7 +5239,7 @@ void CodeCompletionCallbacksImpl::doneParsing() {
   }
   if (auto *DRE = dyn_cast_or_null<DeclRefExpr>(ParsedExpr)) {
     Lookup.setIsSelfRefExpr(DRE->getDecl()->getFullName() == Context.Id_self);
-  } else if (auto *SRE = dyn_cast_or_null<SuperRefExpr>(ParsedExpr)) {
+  } else if (ParsedExpr && isa<SuperRefExpr>(ParsedExpr)) {
     Lookup.setIsSuperRefExpr();
   }
 

lib/Parse/ParseDecl.cpp

@@ -6397,7 +6397,7 @@ void Parser::parseAbstractFunctionBody(AbstractFunctionDecl *AFD) {
             return;
           }
         }
-        if (auto F = dyn_cast<FuncDecl>(AFD)) {
+        if (isa<FuncDecl>(AFD)) {
           auto RS = new (Context) ReturnStmt(SourceLoc(), E);
           BS->setFirstElement(RS);
           AFD->setHasSingleExpressionBody();

lib/SILOptimizer/Transforms/CopyPropagation.cpp

@@ -615,7 +615,7 @@ static bool computeLiveness(CopyPropagationState &pass) {
       // point of the end_borrow.
       if (auto *BBI = dyn_cast<BeginBorrowInst>(user)) {
         for (Operand *use : BBI->getUses()) {
-          if (auto *EBI = dyn_cast<EndBorrowInst>(use->getUser()))
+          if (isa<EndBorrowInst>(use->getUser()))
             computeUseLiveness(use, pass);
         }
         continue;

lib/Sema/BuilderTransform.cpp

@@ -266,7 +266,7 @@ class BuilderClosureVisitor
           continue;
 
         // Skip #warning/#error; we'll handle them when applying the builder.
-        if (auto poundDiag = dyn_cast<PoundDiagnosticDecl>(decl)) {
+        if (isa<PoundDiagnosticDecl>(decl)) {
           continue;
         }