[distributed] working on runtime allocation function

Author: kavon

include/swift/AST/Builtins.def

@@ -727,7 +727,7 @@ BUILTIN_MISC_OPERATION(InitializeDefaultActor, "initializeDefaultActor", "", Spe
 /// Destroy the default-actor instance in a default actor object.
 BUILTIN_MISC_OPERATION(DestroyDefaultActor, "destroyDefaultActor", "", Special)
 
-/// Initialize a "proxy" for a distributed remote actor.
+/// Allocate a "proxy" for a distributed remote actor.  TODO(distributed) change the naming throughout.
 BUILTIN_MISC_OPERATION(InitializeDistributedRemoteActor,
                        "initializeDistributedRemoteActor", "", Special)
 

include/swift/Runtime/RuntimeFunctions.def

@@ -1687,12 +1687,12 @@ FUNCTION(DefaultActorDeallocateResilient,
          ARGS(RefCountedPtrTy),
          ATTRS(NoUnwind))
 
-// void swift_distributedActor_remote_initialize(DefaultActor *actor);
+// void swift_distributedActor_remote_initialize(const Metadata *actorType);
 FUNCTION(DistributedActorInitializeRemote,
          swift_distributedActor_remote_initialize, SwiftCC,
          ConcurrencyAvailability,
-         RETURNS(VoidTy),
-         ARGS(RefCountedPtrTy), // TODO also address and transport?
+         RETURNS(OpaquePtrTy),
+         ARGS(TypeMetadataPtrTy),
          ATTRS(NoUnwind))
 
 // OpaqueValue* swift_distributedActor_remote_create(

lib/SILGen/SILGenConstructor.cpp

@@ -1202,5 +1202,24 @@ void SILGenFunction::emitDistributedActorFactory(FuncDecl *fd) {
   /// NOTE: this will only be reached if the resolve function is actually
   ///       demanded. For example, by declaring the actor as `public` or
   ///       having at least one call to the resolve init.
-  llvm_unreachable("TODO: implement emitDistributedActorFactory");
+
+  SILLocation loc = fd; // NOTE: forgot if this is the right one for all locs.
+  ClassDecl *actor = cast<ClassDecl>(fd->getDeclContext()->getAsDecl());
+  assert(actor->isDistributedActor());
+
+  // Step 1: get the uninitialized allocation from the runtime system.
+  auto &ctx = getASTContext();
+  auto builtinName = ctx.getIdentifier(
+      getBuiltinName(BuiltinValueKind::InitializeDistributedRemoteActor));
+  auto returnType = getLoweredType(actor->getInterfaceType());
+  auto *metaTypeInfo = F.getArgument(0);
+
+  FullExpr scope(Cleanups, CleanupLocation(fd));
+  auto *result = B.createBuiltin(loc, builtinName, returnType, /*subs*/{},
+                  { metaTypeInfo });
+
+  // TODO: initialize the id and transport fields
+
+
+  B.createReturn(loc, result);
 }

lol

@@ -1752,10 +1752,20 @@ void swift::swift_defaultActor_deallocateResilient(HeapObject *actor) {
                       metadata->getInstanceAlignMask());
 }
 
-// TODO: most likely where we'd need to create the "proxy instance" instead? (most likely remove this and use swift_distributedActor_remote_create instead)
-void swift::swift_distributedActor_remote_initialize(DefaultActor *_actor) { // FIXME: remove distributed C++ impl not needed?
-  auto actor = asImpl(_actor);
-  actor->initialize(/*remote=*/true);
+// TODO: rename initialize to allocate throughout htis built-in. Delete `swift_distributedActor_remote_create` throughout.
+OpaqueValue* swift::swift_distributedActor_remote_initialize(Metadata *actorType) {
+  auto *classMetadata = actorType->getClassObject();
+
+  // TODOs:
+  //  1. make this allocation smaller
+  //  2. if we are going to keep the remote flag in the header,
+  //     allocate that header and mark / register this as being remote instance.
+
+  HeapObject *alloc = swift_allocObject(classMetadata,
+                           classMetadata->getInstanceSize(),
+                           classMetadata->getInstanceAlignMask());
+
+  return reinterpret_cast<OpaqueValue*>(alloc);
 }
 
 // TODO: missing implementation of creating a proxy for the remote actor

stdlib/public/Concurrency/Actor.cpp

@@ -208,7 +208,7 @@ func __isLocalActor(_ actor: AnyObject) -> Bool {
 /// Called to initialize the distributed-remote actor 'proxy' instance in an actor.
 /// The implementation will call this within the actor's initializer.
 @_silgen_name("swift_distributedActor_remote_initialize")
-func _distributedActorRemoteInitialize(_ actor: AnyObject)
+func _distributedActorRemoteInitialize(_ actorType: Builtin.RawPointer) -> Any
 
 @_silgen_name("swift_distributedActor_remote_create")
 func distributedActorRemoteCreate(identity: Any, transport: Any) -> Any // TODO: make it typed