[CSSimplify] Guard against null locator in isSelfRecursiveKeyPathDynamicMemberLookup (swiftlang#29886)

Author: theblixguy

lib/Sema/CSSimplify.cpp

@@ -5382,7 +5382,8 @@ static bool isSelfRecursiveKeyPathDynamicMemberLookup(
     ConstraintSystem &cs, Type keyPathRootTy, ConstraintLocator *locator) {
   // Let's check whether this is a recursive call to keypath
   // dynamic member lookup on the same type.
-  if (!locator->isLastElement<LocatorPathElt::KeyPathDynamicMember>())
+  if (!locator ||
+      !locator->isLastElement<LocatorPathElt::KeyPathDynamicMember>())
     return false;
 
   auto path = locator->getPath();

test/Index/Store/dynamic-member-lookup-crash-1.swift

@@ -0,0 +1,18 @@
+// Ensure that we don't crash looking for default implementations during indexing.
+
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -index-store-path %t/idx -o %t/file.o -typecheck -primary-file %s -verify
+
+@dynamicMemberLookup
+public protocol Foo {
+  associatedtype Value
+  
+  var value: Value { get }
+  subscript<U>(dynamicMember keyPath: KeyPath<Value, U>) -> U { get }
+}
+
+extension Foo {
+  public var value: Value {
+    fatalError()
+  }
+}