Add some missing @lifetime attributes

We were relying on infererred lifetimes by accident — it’s better to spell things out for now.

Author: lorentey

stdlib/public/core/Optional.swift

@@ -365,6 +365,7 @@ extension Optional where Wrapped: ~Escapable {
 extension Optional where Wrapped: ~Copyable & ~Escapable {
   // FIXME(NCG): Do we want this? It seems like we do. Make this public.
   @_alwaysEmitIntoClient
+  @lifetime(copy self)
   public consuming func _consumingUnsafelyUnwrap() -> Wrapped {
     switch consume self {
     case .some(let x):
@@ -384,6 +385,7 @@ extension Optional where Wrapped: ~Escapable {
   @_preInverseGenerics
   internal var _unsafelyUnwrappedUnchecked: Wrapped {
     @inline(__always)
+    @lifetime(copy self)
     get {
       if let x = self {
         return x
@@ -476,11 +478,13 @@ extension Optional: CustomReflectable {
 
 @_transparent
 public // COMPILER_INTRINSIC
-func _diagnoseUnexpectedNilOptional(_filenameStart: Builtin.RawPointer,
-                                    _filenameLength: Builtin.Word,
-                                    _filenameIsASCII: Builtin.Int1,
-                                    _line: Builtin.Word,
-                                    _isImplicitUnwrap: Builtin.Int1) {
+func _diagnoseUnexpectedNilOptional(
+  _filenameStart: Builtin.RawPointer,
+  _filenameLength: Builtin.Word,
+  _filenameIsASCII: Builtin.Int1,
+  _line: Builtin.Word,
+  _isImplicitUnwrap: Builtin.Int1
+) {
   // Cannot use _preconditionFailure as the file and line info would not be
   // printed.
   if Bool(_isImplicitUnwrap) {

stdlib/public/core/Result.swift

@@ -138,6 +138,7 @@ extension Result where Success: ~Copyable & ~Escapable {
   /// - Returns: A `Result` instance with the result of evaluating `transform`
   ///   as the new failure value if this instance represents a failure.
   @_alwaysEmitIntoClient
+  @lifetime(copy self)
   public consuming func mapError<NewFailure>(
     _ transform: (Failure) -> NewFailure
   ) -> Result<Success, NewFailure> {