ASTScope: Fix source range of ClosureParametersScope

slavapestov · slavapestov · commit df1b6317221c · 2020-09-16T20:07:58.000-04:00
The parameters are visible inside the source range that begins
with the 'in' keyword and ends with the closure's closing brace.
diff --git a/lib/AST/ASTScopeSourceRange.cpp b/lib/AST/ASTScopeSourceRange.cpp
@@ -456,8 +456,7 @@ SourceRange ClosureParametersScope::getSourceRangeOfThisASTNode(
   if (!omitAssertions)
     ASTScopeAssert(closureExpr->getInLoc().isValid(),
                    "We don't create these if no in loc");
-  return SourceRange(getStartOfFirstParam(closureExpr),
-                     closureExpr->getInLoc());
+  return SourceRange(closureExpr->getInLoc(), closureExpr->getEndLoc());
 }
 
 SourceRange

Original file line number	Diff line number	Diff line change
`@@ -456,8 +456,7 @@ SourceRange ClosureParametersScope::getSourceRangeOfThisASTNode(`
`456`	`456`	`if (!omitAssertions)`
`457`	`457`	`ASTScopeAssert(closureExpr->getInLoc().isValid(),`
`458`	`458`	`"We don't create these if no in loc");`
`459`		`- return SourceRange(getStartOfFirstParam(closureExpr),`
`460`		`- closureExpr->getInLoc());`
	`459`	`+ return SourceRange(closureExpr->getInLoc(), closureExpr->getEndLoc());`
`461`	`460`	`}`
`462`	`461`
`463`	`462`	`SourceRange`