[Distributed] fix access level of synthesized default dist init

Author: ktoso

lib/Sema/CodeSynthesis.cpp

@@ -321,6 +321,9 @@ static ConstructorDecl *createImplicitConstructor(NominalTypeDecl *decl,
            "Only 'distributed actor' type can gain implicit distributed actor init");
 
     if (swift::ensureDistributedModuleLoaded(decl)) {
+      // copy access level of distributed actor init from the nominal decl
+      accessLevel = decl->getEffectiveAccess();
+
       auto transportDecl = ctx.getActorTransportDecl();
 
       // Create the parameter.

lib/Sema/DerivedConformanceDistributedActor.cpp

@@ -160,8 +160,6 @@ static ValueDecl *deriveDistributedActor_actorTransport(
 
 ValueDecl *DerivedConformance::deriveDistributedActor(ValueDecl *requirement) {
   if (auto var = dyn_cast<VarDecl>(requirement)) {
-    fprintf(stderr, "[%s:%d] (%s) DERIVE: [%s]\n", __FILE__, __LINE__, __FUNCTION__, var->getName().str().str().c_str());
-
     if (var->getName() == Context.Id_id)
       return deriveDistributedActor_id(*this);
 
@@ -170,8 +168,6 @@ ValueDecl *DerivedConformance::deriveDistributedActor(ValueDecl *requirement) {
   }
 
   if (auto func = dyn_cast<FuncDecl>(requirement)) {
-    fprintf(stderr, "[%s:%d] (%s) DERIVE: [%s]\n", __FILE__, __LINE__, __FUNCTION__, func->getName().getBaseIdentifier().str().str().c_str());
-
     // just a simple name check is enough here,
     // if we are invoked here we know for sure it is for the "right" function
     if (func->getName().getBaseName() == Context.Id_resolve)

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -2930,21 +2930,6 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
 
     TypeChecker::checkDeclAttributes(ED);
 
-    fprintf(stderr, "[%s:%d] (%s) VISIT EXTENSION\n", __FILE__, __LINE__, __FUNCTION__);
-    if (nominal->isDistributedActor()) {
-      auto decl = dyn_cast<ClassDecl>(nominal);
-      TypeChecker::checkDistributedActor(decl);
-
-      fprintf(stderr, "[%s:%d] (%s) VISIT DIST ACTOR MEMBERS FROM EXTENSION\n", __FILE__, __LINE__, __FUNCTION__);
-      for (Decl *Member : ED->getMembers()) {
-        if (auto var = dyn_cast<VarDecl>(Member))
-          fprintf(stderr, "[%s:%d] (%s) VISIT MEMBER: [%s]\n", __FILE__, __LINE__, __FUNCTION__, var->getName().str().str().c_str());
-        if (auto func = dyn_cast<FuncDecl>(Member))
-          fprintf(stderr, "[%s:%d] (%s) VISIT MEMBER: [%s]\n", __FILE__, __LINE__, __FUNCTION__, func->getName().getBaseName().getIdentifier().str().str().c_str());
-      }
-
-    }
-
     for (Decl *Member : ED->getMembers())
       visit(Member);
 
@@ -2955,6 +2940,11 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     checkAccessControl(ED);
 
     checkExplicitAvailability(ED);
+
+    if (nominal->isDistributedActor()) {
+      auto decl = dyn_cast<ClassDecl>(nominal);
+      TypeChecker::checkDistributedActor(decl);
+    }
   }
 
   void visitTopLevelCodeDecl(TopLevelCodeDecl *TLCD) {

lib/Sema/TypeCheckDistributed.cpp

@@ -215,7 +215,6 @@ void swift::checkDistributedActorConstructor(const ClassDecl *decl, ConstructorD
 // ==== ------------------------------------------------------------------------
 
 void TypeChecker::checkDistributedActor(ClassDecl *decl) {
-  fprintf(stderr, "[%s:%d] (%s) CHECK DIST [%s]\n", __FILE__, __LINE__, __FUNCTION__, decl->getNameStr().str().c_str());
   if (!decl)
     return;
 

test/Serialization/distributed.swift

@@ -14,7 +14,7 @@ import _Distributed
 import def_distributed
 
 func testDoSomethingDistributed(transport: ActorTransport) {
-  let da = DA(transport: transport)
+  let _: DA = DA(transport: transport)
 }
 
 extension DA {