Skip to content

Commit e112581

Browse files
committed
[run-test] Fix --target and --param parsing.
For argparse, the type value of each argument must be a callable. The previous type was simply pointing to the class that implements the callable, and not to an instance of it. This should recover the previous functionality for the --target and the --param arguments. Seems that this is already applied in the build-script, so no changes are necessary there.
1 parent 713e636 commit e112581

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

utils/run-test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def main():
129129
help="build test dependencies before running tests "
130130
"(default: true)")
131131
parser.add_argument("--target",
132-
type=argparse.types.ShellSplitType,
132+
type=argparse.types.ShellSplitType(),
133133
action=argparse.actions.AppendAction,
134134
dest="targets",
135135
help="stdlib deployment targets to test. Accept "
@@ -141,7 +141,7 @@ def main():
141141
choices=TEST_SUBSETS, default='primary',
142142
help="test subset (default: primary)")
143143
parser.add_argument("--param",
144-
type=argparse.types.ShellSplitType,
144+
type=argparse.types.ShellSplitType(),
145145
action=argparse.actions.AppendAction,
146146
default=[],
147147
help="key=value parameters they are directly passed "

0 commit comments

Comments
 (0)