Skip to content

Commit e13e90b

Browse files
committed
[benchmark] Adjust lit tests for Benchmark_O
Change the test to work after removal of `HashQuadratic`.
1 parent 8e67642 commit e13e90b

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

test/benchmark/Benchmark_O.test.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ as a verification of this public API to prevent its accidental breakage.
1414
[BD]: https://github.com/apple/swift/blob/master/benchmark/scripts/Benchmark_Driver
1515
[Testing]: https://github.com/apple/swift/blob/master/docs/Testing.md
1616

17-
Note: Following tests use *HashQuadratic* as an example of a benchmark that is
18-
excluded from the default "pre-commit" list because it is marked `unstable` and
19-
the default skip-tags (`unstable,skip`) will exclude it. The *Ackermann* and
17+
Note: Following tests use *Existential.* as an example of a benchmarks that are
18+
excluded from the default "pre-commit" list because they are marked `skip` and
19+
the default skip-tags (`unstable,skip`) will exclude them. The *Ackermann* and
2020
*AngryPhonebook* are alphabetically the first two benchmarks in the test suite
2121
(used to verify running by index). If these assumptions change, the test must be
2222
adapted.
@@ -27,22 +27,22 @@ RUN: %Benchmark_O --list | %FileCheck %s \
2727
RUN: --check-prefix LISTPRECOMMIT \
2828
RUN: --check-prefix LISTTAGS
2929
LISTPRECOMMIT: #,Test,[Tags]
30-
LISTPRECOMMIT-NOT: HashQuadratic
30+
LISTPRECOMMIT-NOT: Existential.
3131
LISTPRECOMMIT: {{[0-9]+}},AngryPhonebook
3232
LISTTAGS-SAME: ,[
3333
LISTTAGS-NOT: TestsUtils.BenchmarkCategory.
3434
LISTTAGS-SAME: String, api, validation
3535
LISTTAGS-SAME: ]
3636
````
3737

38-
Verify HashQuadratic is listed when skip-tags are explicitly empty and that it
39-
is marked unstable:
38+
Verify `Existential.` benchmarks are listed when skip-tags are explicitly empty
39+
and that they are marked `skip`:
4040

4141
````
4242
RUN: %Benchmark_O --list --skip-tags= | %FileCheck %s --check-prefix LISTALL
4343
LISTALL: AngryPhonebook
44-
LISTALL: HashQuadratic
45-
LISTALL-SAME: unstable
44+
LISTALL: Existential.
45+
LISTALL-SAME: skip
4646
````
4747

4848
## Benchmark Selection
@@ -54,8 +54,9 @@ It provides us with ability to do a "dry run".
5454
Run benchmark by name (even if its tags match the skip-tags) or test number:
5555

5656
````
57-
RUN: %Benchmark_O HashQuadratic --list | %FileCheck %s --check-prefix NAMEDSKIP
58-
NAMEDSKIP: HashQuadratic
57+
RUN: %Benchmark_O Existential.Mutating.Ref1 --list \
58+
RUN: | %FileCheck %s --check-prefix NAMEDSKIP
59+
NAMEDSKIP: Existential.Mutating.Ref1
5960
6061
RUN: %Benchmark_O 1 --list | %FileCheck %s --check-prefix RUNBYNUMBER
6162
RUNBYNUMBER: Ackermann

0 commit comments

Comments
 (0)