[SourceKit] Disable completion-like cursor info for ParamDecls

Author: ahoppen

lib/IDE/CursorInfo.cpp

@@ -150,7 +150,10 @@ class NodeFinder : ASTWalker {
     }
 
     if (auto VD = dyn_cast<ValueDecl>(D)) {
-      if (VD->hasName()) {
+      // FIXME: ParamDecls might be closure parameters that can have ambiguous
+      // types. The current infrastructure of just asking for the VD's type
+      // doesn't work here. We need to inspect the constraints system solution.
+      if (VD->hasName() && !isa<ParamDecl>(D)) {
         assert(Result == nullptr);
         Result = std::make_unique<NodeFinderDeclResult>(VD);
         return Action::Stop();

test/SourceKit/CursorInfo/cursor_on_closure_parameter.swift

@@ -0,0 +1,8 @@
+func save(_ record: Int, _ x: (String) -> Void) {}
+
+func test() {
+  let record = 2
+// RUN: %sourcekitd-test -req=cursor -pos=%(line + 1):19 %s -- %s
+  save(record) { (record) in
+  }
+}