Merge pull request swiftlang#28122 from CodaFi/destroyer-of-minds

CodaFi · web-flow · commit e4899444553c · 2019-11-06T19:07:42.000-08:00
Register a Deleter for the Global TypeChecker Harder This Time
diff --git a/lib/Sema/TypeChecker.cpp b/lib/Sema/TypeChecker.cpp
@@ -56,7 +56,7 @@ TypeChecker &TypeChecker::createForContext(ASTContext &ctx) {
          "Cannot install more than one instance of the global type checker!");
   auto *TC = new TypeChecker(ctx);
   ctx.installGlobalTypeChecker(TC);
-  ctx.addDestructorCleanup(TC);
+  ctx.addCleanup([=](){ delete TC; });
   return *ctx.getLegacyGlobalTypeChecker();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ TypeChecker &TypeChecker::createForContext(ASTContext &ctx) {`
`56`	`56`	`"Cannot install more than one instance of the global type checker!");`
`57`	`57`	`auto *TC = new TypeChecker(ctx);`
`58`	`58`	`ctx.installGlobalTypeChecker(TC);`
`59`		`- ctx.addDestructorCleanup(TC);`
	`59`	`+ ctx.addCleanup([=](){ delete TC; });`
`60`	`60`	`return *ctx.getLegacyGlobalTypeChecker();`
`61`	`61`	`}`
`62`	`62`