Skip to content

Commit e545557

Browse files
committed
remove redundant defers, now that actorReady is called implicitly
1 parent efe8f5d commit e545557

File tree

3 files changed

+5
-16
lines changed

3 files changed

+5
-16
lines changed

test/Distributed/Runtime/distributed_actor_deinit.swift

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,19 @@ actor A {}
1717

1818
@available(SwiftStdlib 5.5, *)
1919
distributed actor DA {
20-
init(transport: ActorTransport) {
21-
defer { transport.actorReady(self) } // FIXME(distributed): rdar://81783599 this should be injected automatically
22-
}
20+
init(transport: ActorTransport) {}
2321
}
2422

2523
@available(SwiftStdlib 5.5, *)
2624
distributed actor DA_userDefined {
27-
init(transport: ActorTransport) {
28-
defer { transport.actorReady(self) } // FIXME(distributed): rdar://81783599 this should be injected automatically
29-
}
25+
init(transport: ActorTransport) {}
3026

3127
deinit {}
3228
}
3329

3430
@available(SwiftStdlib 5.5, *)
3531
distributed actor DA_userDefined2 {
36-
init(transport: ActorTransport) {
37-
defer { transport.actorReady(self) } // FIXME(distributed): rdar://81783599 this should be injected automatically
38-
}
32+
init(transport: ActorTransport) {}
3933

4034
deinit {
4135
print("Deinitializing \(self.id)")
@@ -48,9 +42,7 @@ distributed actor DA_state {
4842
var name = "Hello"
4943
var age = 42
5044

51-
init(transport: ActorTransport) {
52-
defer { transport.actorReady(self) } // FIXME(distributed): rdar://81783599 this should be injected automatically
53-
}
45+
init(transport: ActorTransport) {}
5446

5547
deinit {
5648
print("Deinitializing \(self.id)")

test/Distributed/Runtime/distributed_actor_dynamic_remote_func.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
import _Distributed
1414

1515
distributed actor LocalWorker {
16-
init(transport: ActorTransport) {
17-
defer { transport.actorReady(self) } // FIXME(distributed): rdar://81783599 this should be injected automatically
18-
}
16+
init(transport: ActorTransport) {}
1917

2018
distributed func function() async throws -> String {
2119
"local:"

test/Distributed/distributed_actor_initialization.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ struct FakeTransport: ActorTransport {
101101
distributed actor OKSpecificTransportType {
102102

103103
init(y: Int, transport fake: FakeTransport) { // ok
104-
defer { fake.actorReady(self) }
105104
// nothing
106105
}
107106

0 commit comments

Comments
 (0)