[CSApply] Remove obsolete diagnoseInvalidDynamicConstructorReferences

Author: xedin

lib/Sema/CSApply.cpp

@@ -342,74 +342,6 @@ static bool buildObjCKeyPathString(KeyPathExpr *E,
   return true;
 }
 
-/// Determine whether the given type refers to a non-final class (or
-/// dynamic self of one).
-static bool isNonFinalClass(Type type) {
-  if (auto dynamicSelf = type->getAs<DynamicSelfType>())
-    type = dynamicSelf->getSelfType();
-
-  if (auto classDecl = type->getClassOrBoundGenericClass())
-    return !classDecl->isFinal();
-
-  if (auto archetype = type->getAs<ArchetypeType>())
-    if (auto super = archetype->getSuperclass())
-      return isNonFinalClass(super);
-
-  if (type->isExistentialType())
-    return true;
-
-  return false;
-}
-
-static bool
-diagnoseInvalidDynamicConstructorReferences(ConstraintSystem &cs,
-                                            Expr *base,
-                                            DeclNameLoc memberRefLoc,
-                                            ConstructorDecl *ctorDecl,
-                                            bool SuppressDiagnostics) {
-  auto &tc = cs.getTypeChecker();
-  auto baseTy = cs.getType(base)->getRValueType();
-  auto instanceTy = baseTy->getMetatypeInstanceType();
-
-  bool isStaticallyDerived =
-    base->isStaticallyDerivedMetatype(
-      [&](const Expr *expr) -> Type {
-        return cs.getType(expr);
-      });
-
-  // FIXME: The "hasClangNode" check here is a complete hack.
-  if (isNonFinalClass(instanceTy) &&
-      !isStaticallyDerived &&
-      !ctorDecl->hasClangNode() &&
-      !(ctorDecl->isRequired() ||
-        ctorDecl->getDeclContext()->getSelfProtocolDecl())) {
-    if (SuppressDiagnostics)
-      return false;
-
-    tc.diagnose(memberRefLoc, diag::dynamic_construct_class, instanceTy)
-      .highlight(base->getSourceRange());
-    auto ctor = cast<ConstructorDecl>(ctorDecl);
-    tc.diagnose(ctorDecl, diag::note_nonrequired_initializer,
-                ctor->isImplicit(), ctor->getFullName());
-  // Constructors cannot be called on a protocol metatype, because there is no
-  // metatype to witness it.
-  } else if (isa<ConstructorDecl>(ctorDecl) &&
-             baseTy->is<MetatypeType>() &&
-             instanceTy->isExistentialType()) {
-    if (SuppressDiagnostics)
-      return false;
-
-    if (isStaticallyDerived) {
-      tc.diagnose(memberRefLoc, diag::construct_protocol_by_name, instanceTy)
-        .highlight(base->getSourceRange());
-    } else {
-      tc.diagnose(memberRefLoc, diag::construct_protocol_value, baseTy)
-        .highlight(base->getSourceRange());
-    }
-  }
-  return true;
-}
-
 /// Form a type checked expression for the index of a @dynamicMemberLookup
 /// subscript index parameter.
 /// The index expression will have a tuple type of `(dynamicMember: T)`.