Drop overridable entry point for swift_asyncLet_start.

This entry point is a small shim over `swift_task_create_common`, which
is overridable. We don't need a separate override point here.

Author: DougGregor

stdlib/public/CompatibilityOverride/CompatibilityOverrideConcurrency.def

@@ -159,18 +159,6 @@ OVERRIDE_TASK(task_asyncMainDrainQueue, void,
               SWIFT_EXPORT_FROM(swift_Concurrency), SWIFT_CC(swift), swift::,
               , )
 
-OVERRIDE_ASYNC_LET(asyncLet_start, void,
-                   SWIFT_EXPORT_FROM(swift_Concurrency), SWIFT_CC(swift),
-                   swift::,
-                   (AsyncLet *alet,
-                    TaskOptionRecord *options,
-                    const Metadata *futureResultType,
-                    void *closureEntryPoint,
-                    HeapObject *closureContext
-                   ),
-                   (alet, options,
-                    futureResultType, closureEntryPoint, closureContext))
-
 OVERRIDE_ASYNC_LET(asyncLet_wait, void, SWIFT_EXPORT_FROM(swift_Concurrency),
                    SWIFT_CC(swiftasync), swift::,
                    (OpaqueValue *result,

stdlib/public/Concurrency/AsyncLet.cpp

@@ -101,11 +101,11 @@ void swift::asyncLet_addImpl(AsyncTask *task, AsyncLet *asyncLet) {
 // ==== start ------------------------------------------------------------------
 
 SWIFT_CC(swift)
-static void swift_asyncLet_startImpl(AsyncLet *alet,
-                                     TaskOptionRecord *options,
-                                     const Metadata *futureResultType,
-                                     void *closureEntryPoint,
-                                     HeapObject *closureContext) {
+void swift::swift_asyncLet_start(AsyncLet *alet,
+                                 TaskOptionRecord *options,
+                                 const Metadata *futureResultType,
+                                 void *closureEntryPoint,
+                                 HeapObject *closureContext) {
   auto flags = TaskCreateFlags();
   flags.setEnqueueJob(true);
 

unittests/runtime/CompatibilityOverrideConcurrency.cpp

@@ -169,10 +169,6 @@ TEST_F(CompatibilityOverrideConcurrencyTest,
   swift_continuation_throwingResumeWithError(nullptr, nullptr);
 }
 
-TEST_F(CompatibilityOverrideConcurrencyTest, test_swift_asyncLet_start) {
-  swift_asyncLet_start(nullptr, nullptr, nullptr, nullptr, nullptr);
-}
-
 TEST_F(CompatibilityOverrideConcurrencyTest, test_swift_asyncLet_wait) {
   swift_asyncLet_wait(nullptr, nullptr, nullptr, nullptr, nullptr);
 }