[region-isolation] Ensure that global actor guarded globals are treated as being actor specific state.

So for instance, one cannot transfer them, just like actor state.

Author: gottesmm

lib/SILOptimizer/Analysis/RegionAnalysis.cpp

@@ -2924,6 +2924,17 @@ TrackableValue RegionAnalysisValueMap::getTrackableValue(
           iter.first->getSecond().addFlag(TrackableValueFlag::isActorDerived);
         }
       }
+
+      // See if the memory base is a global_addr from a global actor protected global.
+      if (auto *ga = dyn_cast<GlobalAddrInst>(storage.base)) {
+        if (auto *global = ga->getReferencedGlobal()) {
+          if (auto *globalDecl = global->getDecl()) {
+            if (getActorIsolation(globalDecl).isGlobalActor()) {
+              iter.first->getSecond().addFlag(TrackableValueFlag::isActorDerived);
+            }
+          }
+        }
+      }
     }
   }
 

test/Concurrency/transfernonsendable_globalactors.swift

@@ -0,0 +1,53 @@
+// RUN: %target-swift-frontend -emit-sil -strict-concurrency=complete -enable-experimental-feature RegionBasedIsolation -disable-availability-checking -verify -verify-additional-prefix tns-  %s -o /dev/null -parse-as-library
+
+// Tests specific to global actors.
+
+// REQUIRES: concurrency
+// REQUIRES: asserts
+
+////////////////////////
+// MARK: Declarations //
+////////////////////////
+
+class Klass {}
+
+struct NonSendableStruct {
+  var first = Klass()
+  var second = Klass()
+}
+
+func useValue<T>(_ t: T) {}
+func getAny() -> Any { fatalError() }
+
+actor Custom {
+}
+
+@globalActor
+struct CustomActor {
+    static var shared: Custom {
+        return Custom()
+    }
+}
+
+@MainActor func transferToMain<T>(_ t: T) {}
+@CustomActor func transferToCustom<T>(_ t: T) {}
+
+@MainActor var globalKlass = Klass()
+
+/////////////////
+// MARK: Tests //
+/////////////////
+
+@MainActor func testTransferGlobalActorGuardedValue() async {
+  await transferToCustom(globalKlass) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+}
+
+@MainActor func testTransferGlobalActorGuardedValueWithlet() async {
+  let x = globalKlass
+  await transferToCustom(x) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+}
+
+@MainActor func testTransferGlobalActorGuardedValueWithlet(_ k: Klass) async {
+  globalKlass = k
+  await transferToCustom(k) // expected-tns-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+}

test/Concurrency/transfernonsendable_strong_transferring.swift

@@ -15,7 +15,19 @@ struct NonSendableStruct {
 
 func useValue<T>(_ t: T) {}
 func getAny() -> Any { fatalError() }
+
+actor Custom {
+}
+
+@globalActor
+struct CustomActor {
+    static var shared: Custom {
+        return Custom()
+    }
+}
+
 @MainActor func transferToMain<T>(_ t: T) {}
+@CustomActor func transferToCustom<T>(_ t: T) {}
 
 func transferArg(_ x: transferring Klass) {
 }
@@ -122,11 +134,27 @@ actor MyActor {
   globalKlass = x
 }
 
+@MainActor func canAssignTransferringIntoGlobalActor2(_ x: transferring Klass) async {
+  globalKlass = x
+  await transferToCustom(x) // expected-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+}
+
+@MainActor func canAssignTransferringIntoGlobalActor3(_ x: transferring Klass) async {
+  await transferToCustom(globalKlass) // expected-warning {{call site passes `self` or a non-sendable argument of this function to another thread, potentially yielding a race with the caller}}
+}
+
 func canTransferAssigningIntoLocal(_ x: transferring Klass) async {
   let _ = x
   await transferToMain(x)
 }
 
+func canTransferAssigningIntoLocal2(_ x: transferring Klass) async {
+  let _ = x
+  await transferToMain(x) // expected-warning {{passing argument of non-sendable type 'Klass' from nonisolated context to main actor-isolated context at this call site could yield a race with accesses later in this function}}
+  let _ = x // expected-note {{access here could race}}
+}
+
+
 //////////////////////////////////////
 // MARK: Transferring is "var" like //
 //////////////////////////////////////