[WIP] Address review comments - Fix memory leak

RAJAGOPALAN-GANGADHARAN · RAJAGOPALAN-GANGADHARAN · commit fd2fcbb7f819 · 2021-08-05T14:53:22.000+05:30
diff --git a/lib/Driver/ToolChains.cpp b/lib/Driver/ToolChains.cpp
@@ -143,10 +143,10 @@ static void addLTOArgs(const OutputInfo &OI, ArgStringList &arguments) {
 }
 
 static void addLinkedLibArgs(const ArgList &Args, ArgStringList &FrontendArgs) {
-  for(auto Arg:Args.getAllArgValues(options::OPT_l))
-  {
-    std::string* lArg = new std::string("-l" + Arg);
-    FrontendArgs.push_back(lArg->c_str());
+  Args.getLastArg(options::OPT_l);
+  for (auto Arg : Args.getAllArgValues(options::OPT_l)) {
+    const std::string lArg("-l" + Arg);
+    FrontendArgs.push_back(Args.MakeArgString(Twine(lArg)));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -143,10 +143,10 @@ static void addLTOArgs(const OutputInfo &OI, ArgStringList &arguments) {`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`static void addLinkedLibArgs(const ArgList &Args, ArgStringList &FrontendArgs) {`
`146`		`- for(auto Arg:Args.getAllArgValues(options::OPT_l))`
`147`		`- {`
`148`		`- std::string* lArg = new std::string("-l" + Arg);`
`149`		`- FrontendArgs.push_back(lArg->c_str());`
	`146`	`+ Args.getLastArg(options::OPT_l);`
	`147`	`+ for (auto Arg : Args.getAllArgValues(options::OPT_l)) {`
	`148`	`+ const std::string lArg("-l" + Arg);`
	`149`	`+ FrontendArgs.push_back(Args.MakeArgString(Twine(lArg)));`
`150`	`150`	`}`
`151`	`151`	`}`
`152`	`152`